From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Marcus Kida <marcus.kida@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: Bug: git branch -D can be used to delete branch which is currently checked out - Part 2
Date: Thu, 10 Mar 2016 13:15:16 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.20.1603101313220.4690@virtualbox> (raw)
In-Reply-To: <F6588CBF-D13E-475F-847F-6154370F4A2E@gmail.com>
Hi Marcus,
On Thu, 10 Mar 2016, Marcus Kida wrote:
> Proposed solution:
>
> Use `strcasecmp`, `stricmp`, `strcmpi` here: https://github.com/git/git/blob/f02fbc4f9433937ee0463d0342d6d7d97e1f6f1e/builtin/branch.c#L218
>
> Not sure if/which one of this will work on POSIX as well as MS too though.
This is not quite a solution (it is not a patch). And you *definitely*
want to make the use of strcasecmp() contingent on ignore_case. You are
not alone on this world, after all, and other people have case-sensitive
filesystems. It's totally doable, of course.
So, do you feel up to the task?
Ciao,
Johannes
next prev parent reply other threads:[~2016-03-10 12:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-10 8:39 Bug: git branch -D can be used to delete branch which is currently checked out - Part 2 Marcus Kida
2016-03-10 12:15 ` Johannes Schindelin [this message]
2016-03-10 18:30 ` Marcus Kida
2016-03-10 22:41 ` Jeff King
2016-03-10 22:43 ` Marcus Kida
2016-03-10 21:20 ` Marcus Kida
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1603101313220.4690@virtualbox \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=marcus.kida@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).