From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Pranit Bauva <pranit.bauva@gmail.com>
Cc: Christian Couder <christian.couder@gmail.com>,
Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>,
Git List <git@vger.kernel.org>,
Stefan Beller <sbeller@google.com>,
Lars Schneider <larsxschneider@gmail.com>,
Jeff King <peff@peff.net>, Troy Moure <troy.moure@gmail.com>,
Junio C Hamano <gitster@pobox.com>,
Eric Sunshine <sunshine@sunshineco.com>,
Kevin Daudt <me@ikke.info>, Philip Oakley <philipoakley@iee.org>
Subject: Re: GSoC Project | Improvise git bisect
Date: Sun, 20 Mar 2016 16:31:07 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.20.1603201628590.4690@virtualbox> (raw)
In-Reply-To: <CAFZEwPP2OLOQanazPXxK1u5GVHzFWqx8GuRad7tLUyHrWR_+Tw@mail.gmail.com>
Hi,
On Sun, 20 Mar 2016, Pranit Bauva wrote:
> The plan:
>
> - Place bisect.c in builtin/
> - Implement a skeletal cmd_bisect() which will redirect to
> git-bisect.sh (1e1ea69f)
I would highly advise a different course of action:
- move functionality one by one from bisect.sh to builtin/bisect--helper.c
That way, you do not have to deal with a lot of infrastructure at the
beginning of your project because bisect--helper is already a builtin;
Instead, you can dive right in and implement satisfyingly noticable
improvements.
Ciao,
Johannes
next prev parent reply other threads:[~2016-03-20 15:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-19 9:33 GSoC Project | Improvise git bisect Pranit Bauva
2016-03-19 12:48 ` Matthieu Moy
2016-03-19 16:14 ` Christian Couder
2016-03-19 16:49 ` Pranit Bauva
2016-03-19 22:05 ` Stefan Beller
2016-03-20 8:10 ` Pranit Bauva
2016-03-20 11:35 ` Pranit Bauva
2016-03-20 13:24 ` Matthieu Moy
2016-03-20 13:25 ` Christian Couder
2016-03-20 15:31 ` Johannes Schindelin [this message]
2016-03-20 16:26 ` Pranit Bauva
2016-03-20 18:08 ` Matthieu Moy
2016-03-21 7:18 ` Johannes Schindelin
2016-03-21 7:29 ` Pranit Bauva
2016-03-21 17:53 ` Christian Couder
2016-03-21 18:13 ` Pranit Bauva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1603201628590.4690@virtualbox \
--to=johannes.schindelin@gmx.de \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=larsxschneider@gmail.com \
--cc=me@ikke.info \
--cc=peff@peff.net \
--cc=philipoakley@iee.org \
--cc=pranit.bauva@gmail.com \
--cc=sbeller@google.com \
--cc=sunshine@sunshineco.com \
--cc=troy.moure@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).