From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] sha1_name.c: add an option to abort on ambiguous refs
Date: Wed, 23 Mar 2016 16:45:42 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.20.1603231642580.4690@virtualbox> (raw)
In-Reply-To: <1458739840-15855-1-git-send-email-pclouds@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 957 bytes --]
Hi Duy,
On Wed, 23 Mar 2016, Nguyễn Thái Ngọc Duy wrote:
> There are cases when a warning on ambiguous refs may go unnoticed
> (e.g. git-log filling up the whole screen). There are also cases when
> people want to catch ambiguity early (e.g. it happens deep in some
> script). In either case, aborting the program would accomplish it.
Whenever I see a die() in code outside of builtin/*.c, I cringe. I do that
because it was *exactly* something like that that caused a serious
regression in the builtin am so that we had to resort back to spawning
separate processes *just so* that we could catch error conditions and
run certain code in that case.
Maybe there would be a way to do what you want to do that does not fly in
the face of libification? Maybe some strbuf with an atexit() that
accumulates fatal errors that might be hidden and that are then written at
the end of the program (colorfully, if isatty(2))?
Ciao,
Dscho
next prev parent reply other threads:[~2016-03-23 15:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-23 13:30 [PATCH] sha1_name.c: add an option to abort on ambiguous refs Nguyễn Thái Ngọc Duy
2016-03-23 15:45 ` Johannes Schindelin [this message]
2016-03-23 23:11 ` Duy Nguyen
2016-06-28 17:55 ` Duy Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1603231642580.4690@virtualbox \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox