Re: [PATCH] send-email: more meaningful Message-ID

[Johannes Schindelin <Johannes.Schindelin@gmx.de>]

Hi,

On Tue, 5 Apr 2016, Eric Wong wrote:

> Junio C Hamano <gitster@pobox.com> wrote:
> > Eric Wong <normalperson@yhbt.net> writes:
> > 
> > > Using a YYYYmmddHHMMSS date representation is more meaningful to
> > > humans, especially when used for lookups on NNTP servers or linking
> > > to archive sites via Message-ID (e.g. mid.gmane.org or
> > > mid.mail-archive.com).  This timestamp format more easily gives a
> > > reader of the URL itself a rough date of a linked message compared
> > > to having them calculate the seconds since the Unix epoch.
> > >
> > > Furthermore, having the MUA name in the Message-ID seems to be a
> > > rare oddity I haven't noticed outside of git-send-email.  We
> > > already have an optional X-Mailer header field to advertise for
> > > us, so extending the Message-ID by 15 characters can make for
> > > unpleasant Message-ID-based URLs to archive sites.
> > >
> > > Signed-off-by: Eric Wong <normalperson@yhbt.net>
> > > ---
> > 
> > Sounds like a sensible goal.  Just a few comments.
> > 
> >  - Is it safe to assume that we always can use POSIX::strftime(), or
> >    do we need some fallback?  I am guessing that this is safe, as
> >    POSIX has been part of the core modules for a long time, and the
> >    script does "use 5.008" upfront.
> 
> I'm hoping so :)  And none of the format specifiers used here
> should be subject to locale-dependent weirdness, at least.
> 
> +Cc both Johannes for Windows knowledge.

Thanks.

send-email is implemented as a Perl script, and Git for Windows uses a
Perl interpreter for such scripts which uses MSYS2's POSIX emulation
layer, i.e. POSIX calls are fine.

Short answer: no problem there, not even on Windows.

Of course, Git for Windows users are much more likely to use a Pull
Request based workflow than a mail-based one, so it is even less of a
problem for us.

Ciao,
Dscho