From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] rebase: convert revert to squash on autosquash
Date: Thu, 7 Apr 2016 17:23:09 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1604071720160.2967@virtualbox> (raw)
In-Reply-To: <1460041965-31526-1-git-send-email-mst@redhat.com>
Hi,
On Thu, 7 Apr 2016, Michael S. Tsirkin wrote:
> Reverts can typically be treated like squash. Eliminating both the
> original commit and the revert would be even nicer, but this seems a bit
> harder to implement.
Whoa. This rings a lot of alarm bells, very loudly. It seems you intend to
introduce a *major* change in behavior, and all we get to convince us that
this is a good change is this puny paragraph (which, by the way, does not
do half a good job of explaining to me what you think this patch is
supposed to do, let alone of convincing me that what you want is a good
change).
So. What is it again that you want to achieve? Please use plain English,
e.g. explaining how exactly reverts are typically to be treated like
squashes. And please make it convincing, because so far, I am far from
convinced.
Ciao,
Johannes
next prev parent reply other threads:[~2016-04-07 15:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-07 15:12 [PATCH] rebase: convert revert to squash on autosquash Michael S. Tsirkin
2016-04-07 15:23 ` Johannes Schindelin [this message]
2016-04-07 15:51 ` Michael S. Tsirkin
2016-04-08 11:13 ` Johannes Schindelin
2016-04-08 11:42 ` Matthieu Moy
2016-04-08 14:09 ` Michael S. Tsirkin
2016-04-08 11:43 ` Michael S. Tsirkin
2016-04-09 17:17 ` Michael S. Tsirkin
2016-04-08 11:39 ` Matthieu Moy
-- strict thread matches above, loose matches on Subject: below --
2014-10-22 6:57 Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1604071720160.2967@virtualbox \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=mst@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).