From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/2] fsck: detect and warn a commit with embedded NUL
Date: Fri, 15 Apr 2016 15:43:52 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1604151541580.2967@virtualbox> (raw)
In-Reply-To: <20160414180709.28968-2-gitster@pobox.com>
Hi Junio,
On Thu, 14 Apr 2016, Junio C Hamano wrote:
> Even though a Git commit object is designed to be capable of storing
> any binary data as its payload, in practice people use it to describe
> the changes in textual form, and tools like "git log" are designed to
> treat the payload as text.
>
> Detect and warn when we see any commit object with a NUL byte in
> it.
>
> Note that a NUL byte in the header part is already detected as a
> grave error. This change is purely about the message part.
IIRC there was some discussion going on about this, and since it was 1)
legal and 2) not checked before, I decided not to make this an error.
But of course it is good to introduce a warning!
Thank you,
Dscho
next prev parent reply other threads:[~2016-04-15 13:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-14 18:07 [PATCH 1/2] fsck_commit_buffer(): do not special case the last validation Junio C Hamano
2016-04-14 18:07 ` [PATCH 2/2] fsck: detect and warn a commit with embedded NUL Junio C Hamano
2016-04-14 18:21 ` Jeff King
2016-04-14 18:25 ` Junio C Hamano
2016-04-14 18:29 ` Jeff King
2016-04-14 19:04 ` Junio C Hamano
2016-04-14 18:25 ` Jeff King
2016-04-14 18:37 ` Junio C Hamano
2016-04-15 13:43 ` Johannes Schindelin [this message]
2016-04-14 18:10 ` [PATCH 1/2] fsck_commit_buffer(): do not special case the last validation Jeff King
2016-04-14 18:15 ` Junio C Hamano
2016-04-15 13:41 ` Johannes Schindelin
2016-04-15 15:06 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1604151541580.2967@virtualbox \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).