From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: XZS <d.f.fischer@web.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH/RFC/GSoC 0/2] add a add.patch config variable
Date: Thu, 21 Apr 2016 17:39:52 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1604211737170.2826@virtualbox> (raw)
In-Reply-To: <cover.1459946531.git.d.f.fischer@web.de>
Hi Dominik,
On Thu, 21 Apr 2016, XZS wrote:
> The following patches try to provide an add.patch configuration variable
> while keeping out of the way of other commands. To do so, an environment
> variable counts how often git was recursively invoked. The variable is
> then only considered in the first recursion.
This dives right into the "how". Maybe a good idea would be to start with
a paragraph that explains the "what" and the "why" first, and only then go
into the details how you implemented it, what other options you considered
and why you preferred your solution?
Even after skimming the patch series, I am still a bit puzzled what issue
it solves...
Ciao,
Johannes
next prev parent reply other threads:[~2016-04-21 15:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-24 21:09 [GSoC] Proposal XZS
2016-03-24 21:09 ` [PATCH/GSoC] add a add.patch config variable XZS
2016-03-24 21:20 ` Junio C Hamano
2016-03-25 0:43 ` Dominik Fischer
2016-03-25 6:30 ` Junio C Hamano
2016-04-21 9:15 ` [PATCH/RFC/GSoC 0/2] " XZS
2016-04-21 9:15 ` [PATCH/RFC/GSoC 1/2] count recursion depth XZS
2016-04-21 9:15 ` [PATCH/RFC/GSoC 2/2] add a add.patch config variable XZS
2016-04-21 15:39 ` Johannes Schindelin [this message]
2016-04-21 16:30 ` [PATCH/RFC/GSoC 0/2] " Dominik Fischer
2016-04-21 16:43 ` Matthieu Moy
2016-04-21 16:47 ` Junio C Hamano
2016-04-21 17:28 ` Dominik Fischer
2016-04-22 6:45 ` Johannes Schindelin
2016-04-22 6:42 ` Johannes Schindelin
2016-03-25 7:01 ` [PATCH/GSoC] " Christian Couder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1604211737170.2826@virtualbox \
--to=johannes.schindelin@gmx.de \
--cc=d.f.fischer@web.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox