From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Dominik Fischer <d.f.fischer@web.de>
Cc: Junio C Hamano <gitster@pobox.com>,
Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>,
git@vger.kernel.org
Subject: Re: [PATCH/RFC/GSoC 0/2] add a add.patch config variable
Date: Fri, 22 Apr 2016 08:45:46 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1604220843310.2826@virtualbox> (raw)
In-Reply-To: <d6747d29-601f-d9ba-2f27-812bf064edff@web.de>
Hi Dominik,
On Thu, 21 Apr 2016, Dominik Fischer wrote:
> Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:
> > any transition plan would be far more painful than the possible benefits
> I agree, it cannot be expected that every external script sets
> GIT_RECURSION_DEPTH before issuing any command just because of this little
> option.
>
> As an exercise for GSoC, I implemented it nonetheless to get more familiar
> with the code base and testing system and receive some feedback. Perhaps the
> counter can even be useful for some actually significant use case in the
> future.
Maybe. We come up with tons of patches all the time, and most do not make
it into the code base, though.
I still think it was a valuable thing to do: you are now much more
familiar with Git's code base. And you now know why the proposed solution
won't work. And I guess the alias is what you'll end up using.
Ciao,
Johannes
next prev parent reply other threads:[~2016-04-22 6:46 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-24 21:09 [GSoC] Proposal XZS
2016-03-24 21:09 ` [PATCH/GSoC] add a add.patch config variable XZS
2016-03-24 21:20 ` Junio C Hamano
2016-03-25 0:43 ` Dominik Fischer
2016-03-25 6:30 ` Junio C Hamano
2016-03-25 7:01 ` Christian Couder
2016-04-21 9:15 ` [PATCH/RFC/GSoC 0/2] " XZS
2016-04-21 9:15 ` [PATCH/RFC/GSoC 1/2] count recursion depth XZS
2016-04-21 15:39 ` [PATCH/RFC/GSoC 0/2] add a add.patch config variable Johannes Schindelin
2016-04-21 16:30 ` Dominik Fischer
2016-04-21 16:43 ` Matthieu Moy
2016-04-21 16:47 ` Junio C Hamano
2016-04-21 17:28 ` Dominik Fischer
2016-04-22 6:45 ` Johannes Schindelin [this message]
2016-04-22 6:42 ` Johannes Schindelin
2016-04-21 9:15 ` [PATCH/RFC/GSoC 2/2] " XZS
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1604220843310.2826@virtualbox \
--to=johannes.schindelin@gmx.de \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=d.f.fischer@web.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).