From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Christian Couder <christian.couder@gmail.com>
Cc: git@vger.kernel.org, "Junio C Hamano" <gitster@pobox.com>,
"Jeff King" <peff@peff.net>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Karsten Blees" <karsten.blees@gmail.com>,
"Nguyen Thai Ngoc Duy" <pclouds@gmail.com>,
"Stefan Beller" <sbeller@google.com>,
"Matthieu Moy" <Matthieu.Moy@grenoble-inp.fr>,
"Christian Couder" <chriscool@tuxfamily.org>
Subject: Re: [PATCH 80/83] run-command: make dup_devnull() non static
Date: Mon, 25 Apr 2016 17:05:09 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1604251704300.2896@virtualbox> (raw)
In-Reply-To: <1461505189-16234-1-git-send-email-chriscool@tuxfamily.org>
Hi Chris,
On Sun, 24 Apr 2016, Christian Couder wrote:
> diff --git a/run-command.c b/run-command.c
> index 8c7115a..29d2bda 100644
> --- a/run-command.c
> +++ b/run-command.c
> @@ -85,7 +85,7 @@ static inline void close_pair(int fd[2])
> }
>
> #ifndef GIT_WINDOWS_NATIVE
> -static inline void dup_devnull(int to)
> +void dup_devnull(int to)
> {
The #ifndef GIT_WINDOWS_NATIVE rings very, very loud alarm bells.
Ciao,
Dscho
next prev parent reply other threads:[~2016-04-25 15:05 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-24 13:39 [PATCH 80/83] run-command: make dup_devnull() non static Christian Couder
2016-04-24 13:39 ` [PATCH 81/83] apply: roll back index in case of error Christian Couder
2016-04-25 16:06 ` Johannes Schindelin
2016-05-02 7:07 ` Johannes Schindelin
2016-05-02 7:18 ` Eric Sunshine
2016-05-03 12:57 ` Christian Couder
2016-04-24 13:39 ` [PATCH 82/83] environment: add set_index_file() Christian Couder
2016-05-03 15:36 ` Junio C Hamano
2016-05-04 11:50 ` Christian Couder
2016-04-24 13:39 ` [PATCH 83/83] builtin/am: use apply api in run_apply() Christian Couder
2016-04-25 15:03 ` Johannes Schindelin
2016-05-05 10:04 ` Christian Couder
2016-04-25 15:05 ` Johannes Schindelin [this message]
2016-05-05 9:50 ` [PATCH 80/83] run-command: make dup_devnull() non static Christian Couder
2016-05-05 20:07 ` Johannes Sixt
2016-05-06 13:56 ` Christian Couder
2016-05-06 15:34 ` Johannes Schindelin
2016-05-07 10:12 ` Christian Couder
2016-05-07 12:13 ` Johannes Schindelin
2016-05-07 13:46 ` Christian Couder
2016-05-08 6:33 ` Johannes Schindelin
2016-05-08 10:15 ` Duy Nguyen
2016-05-09 15:05 ` Johannes Schindelin
2016-05-09 17:40 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1604251704300.2896@virtualbox \
--to=johannes.schindelin@gmx.de \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=avarab@gmail.com \
--cc=chriscool@tuxfamily.org \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=karsten.blees@gmail.com \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).