git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: What's cooking in git.git (May 2016, #02; Fri, 6)
Date: Tue, 10 May 2016 07:59:35 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.20.1605100757410.4092@virtualbox> (raw)
In-Reply-To: <xmqqeg9e24ay.fsf@gitster.mtv.corp.google.com>

Hi Junio,

On Fri, 6 May 2016, Junio C Hamano wrote:

> * jc/fsck-nul-in-commit (2016-04-14) 2 commits
>  - fsck: detect and warn a commit with embedded NUL
>  - fsck_commit_buffer(): do not special case the last validation
> 
>  "git fsck" learned to catch NUL byte in a commit object as
>  potential error and warn.
> 
>  What was the status of this one?  Ready to proceed?

I think this code looks fine. Maybe two comments on the test:

>               test_must_fail git -c fsck.nulInCommit=error fsck 2>warn.1 &&
>               git fsck 2>warn.2 &&
>               grep nulInCommit warn.2

1) warn.1 is not used. Maybe skip that redirection?

2) I was under the impression that we preferred test_i18ngrep over grep...

Thanks,
Dscho

  parent reply	other threads:[~2016-05-10  5:59 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-06 22:46 What's cooking in git.git (May 2016, #02; Fri, 6) Junio C Hamano
2016-05-10  5:52 ` Johannes Schindelin
2016-05-11  7:41   ` Lars Schneider
2016-05-10  5:59 ` Johannes Schindelin [this message]
2016-05-10  7:20   ` Junio C Hamano
2016-05-13 11:52     ` Johannes Schindelin
2016-05-10  6:27 ` Lars Schneider
2016-05-10  7:16   ` Junio C Hamano
2016-05-10 17:07   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.20.1605100757410.4092@virtualbox \
    --to=johannes.schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).