git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: What's cooking in git.git (May 2016, #02; Fri, 6)
Date: Fri, 13 May 2016 13:52:11 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.20.1605131349020.4092@virtualbox> (raw)
In-Reply-To: <xmqqy47iqszk.fsf@gitster.mtv.corp.google.com>

Hi Junio,

On Tue, 10 May 2016, Junio C Hamano wrote:

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> > On Fri, 6 May 2016, Junio C Hamano wrote:
> >
> > 2) I was under the impression that we preferred test_i18ngrep over grep...
> 
> Only when the strings we are expecting are subject to i18n.  I
> somehow did not think your report() codepath has any i18n/l10n?

I finally remembered why I thought that test_i18ngrep was to be preferred
over grep. For years, Git for Windows carried a patch that introduced a
special `cmp` for use with text files, so that differences in the
end-of-line markers could be ignored. IIRC we abandoned this when
test_i18ncmp learned to perform this trick. Only that it really is
test_cmp that learned this trick... so I was wrong.

So please forget what I said about this part of the patch.

Ciao,
Dscho

  reply	other threads:[~2016-05-13 11:52 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-06 22:46 What's cooking in git.git (May 2016, #02; Fri, 6) Junio C Hamano
2016-05-10  5:52 ` Johannes Schindelin
2016-05-11  7:41   ` Lars Schneider
2016-05-10  5:59 ` Johannes Schindelin
2016-05-10  7:20   ` Junio C Hamano
2016-05-13 11:52     ` Johannes Schindelin [this message]
2016-05-10  6:27 ` Lars Schneider
2016-05-10  7:16   ` Junio C Hamano
2016-05-10 17:07   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.20.1605131349020.4092@virtualbox \
    --to=johannes.schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).