t7300-clean.sh fails "not ok 32 - should avoid cleaning possible submodules" on debian jessie

t7300-clean.sh fails "not ok 32 - should avoid cleaning possible submodules" on debian jessie

[Pirate Praveen]

[-- Attachment #1: Type: text/plain, Size: 634 bytes --]

Hi,

I'm trying to rebuild git 2.8.1 on debian jessie/stable and I get this
error (tests upto this succeeds).

not ok 32 - should avoid cleaning possible submodules

I added debian stretch repo to apt sources.list and ran apt-get source
-b git.

You can see the build options passed here
http://repo.or.cz/git/debian.git/blob/HEAD:/debian/rules

Since it is a working fine on debian sid/unstable, I did not want to
report it to debian package maintainers.

I noticed the same failure for git 2.8.0-rc3 as well. I could ignore the
test failure and go ahead, but I'd like to fix this if possible.

Thanks
Praveen


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: t7300-clean.sh fails "not ok 32 - should avoid cleaning possible submodules" on debian jessie

[Johannes Schindelin]

Hi Pirate Praveen,

On Tue, 7 Jun 2016, Pirate Praveen wrote:

> I'm trying to rebuild git 2.8.1 on debian jessie/stable and I get this
> error (tests upto this succeeds).
> 
> not ok 32 - should avoid cleaning possible submodules

How about re-running the script with -i -v -x? If the output is still
not shining enough light on it, maybe you want to paste the (relevant part
of the) output into a reply?

Ciao,
Johannes

Re: t7300-clean.sh fails "not ok 32 - should avoid cleaning possible submodules" on debian jessie

[Pirate Praveen]

[-- Attachment #1: Type: text/plain, Size: 1812 bytes --]

On Tuesday 07 June 2016 04:00 PM, Johannes Schindelin wrote:
> Hi Pirate Praveen,
> 
> On Tue, 7 Jun 2016, Pirate Praveen wrote:
> 
>> I'm trying to rebuild git 2.8.1 on debian jessie/stable and I get this
>> error (tests upto this succeeds).
>>
>> not ok 32 - should avoid cleaning possible submodules
> 
> How about re-running the script with -i -v -x? If the output is still
> not shining enough light on it, maybe you want to paste the (relevant part
> of the) output into a reply?

+ rm -fr to_clean possible_sub1
+ mkdir to_clean possible_sub1
+ test_when_finished rm -rf possible_sub*
+ test 0 = 0
+ test_cleanup={ rm -rf possible_sub*
                } && (exit "$eval_ret"); eval_ret=$?; :
+ echo gitdir: foo
+
+ chmod 0 possible_sub1/.git
+
+ git clean -f -d
Skipping repository baz/boo

Skipping repository foo/
Removing possible_sub1/
Skipping repository repo/
Skipping repository sub2/
Removing to_clean/
+ test_path_is_file possible_sub1/.git
+ test -f possible_sub1/.git
+ echo File possible_sub1/.git doesn't exist.
File possible_sub1/.git doesn't exist.
+ false
error: last command exited with $?=1
not ok 32 - should avoid cleaning possible submodules
#
#               rm -fr to_clean possible_sub1 &&
#               mkdir to_clean possible_sub1 &&
#               test_when_finished "rm -rf possible_sub*" &&
#               echo "gitdir: foo" >possible_sub1/.git &&
#               >possible_sub1/hello.world &&
#               chmod 0 possible_sub1/.git &&
#               >to_clean/should_clean.this &&
#               git clean -f -d &&
#               test_path_is_file possible_sub1/.git &&
#               test_path_is_file possible_sub1/hello.world &&
#               test_path_is_missing to_clean
#

> Ciao,
> Johannes
> 



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: t7300-clean.sh fails "not ok 32 - should avoid cleaning possible submodules" on debian jessie

[Stefan Beller]

http://thread.gmane.org/gmane.comp.version-control.git/293025

TL;DR:  don't run tests as root, or cherry-pick
cadfbef98032fbc6874b5efd70d1e33dbeb4640d
(Are you telling me that patch is faulty?)

Re: t7300-clean.sh fails "not ok 32 - should avoid cleaning possible submodules" on debian jessie

[Stefan Beller]

On Tue, Jun 7, 2016 at 8:43 AM, Stefan Beller <sbeller@google.com> wrote:
> (Are you telling me that patch is faulty?)

The patch is not part of v2.8.1 but part of v2.8.3,
so take a later version, or cherry-pick that patch manually.

Re: t7300-clean.sh fails "not ok 32 - should avoid cleaning possible submodules" on debian jessie

[Pirate Praveen]

On 2016, ജൂൺ 7 9:16:01 PM IST, Stefan Beller <sbeller@google.com> wrote:
>On Tue, Jun 7, 2016 at 8:43 AM, Stefan Beller <sbeller@google.com>
>wrote:
>> (Are you telling me that patch is faulty?)
>
>The patch is not part of v2.8.1 but part of v2.8.3,
>so take a later version, or cherry-pick that patch manually.

Thanks! I have ignored that test failure for now. Good to know its fixed in 2.8.3.

Re: t7300-clean.sh fails "not ok 32 - should avoid cleaning possible submodules" on debian jessie

[Johannes Schindelin]

Hi Pirate Praveen,

On Tue, 7 Jun 2016, Pirate Praveen wrote:

> On Tuesday 07 June 2016 04:00 PM, Johannes Schindelin wrote:
> > Hi Pirate Praveen,
> > 
> > On Tue, 7 Jun 2016, Pirate Praveen wrote:
> > 
> >> I'm trying to rebuild git 2.8.1 on debian jessie/stable and I get this
> >> error (tests upto this succeeds).
> >>
> >> not ok 32 - should avoid cleaning possible submodules
> > 
> > How about re-running the script with -i -v -x? If the output is still
> > not shining enough light on it, maybe you want to paste the (relevant part
> > of the) output into a reply?
> 
> + rm -fr to_clean possible_sub1
> [...]

Sorry, I must have missed your diligent analysis.

Ciao,
Johannes