git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/2] t/perf: fix regression in testing older versions of git
Date: Wed, 22 Jun 2016 22:25:53 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.20.1606222223530.10382@virtualbox> (raw)
In-Reply-To: <20160622194013.GA1697@sigill.intra.peff.net>

Hi Peff,

On Wed, 22 Jun 2016, Jeff King wrote:

> diff --git a/t/perf/README b/t/perf/README
> index 8848c14..15986ca 100644
> --- a/t/perf/README
> +++ b/t/perf/README
> @@ -115,8 +115,16 @@ After that you will want to use some of the following:
>  
>  At least one of the first two is required!
>  
> -You can use test_expect_success as usual.  For actual performance
> -tests, use
> +You can use test_expect_success as usual. In both test_expect_success
> +and in test_perf, running "git" points to the version that is being
> +peft-tested. The $MODERN_GIT variable points to the git wrapper for the

s/peft/perf/

Or s/peft/peff/. :-)

The rest looks fine!
Dscho

  parent reply	other threads:[~2016-06-22 20:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-22 19:39 [PATCH 0/2] t/perf tests against older versions Jeff King
2016-06-22 19:40 ` [PATCH 1/2] t/perf: fix regression in testing older versions of git Jeff King
2016-06-22 20:23   ` Johannes Schindelin
2016-06-22 20:25   ` Johannes Schindelin [this message]
2016-06-22 20:46   ` Junio C Hamano
2016-06-22 20:48     ` Jeff King
2016-06-22 20:51       ` Junio C Hamano
2016-06-22 19:40 ` [PATCH 2/2] p4211: explicitly disable renames in no-rename test Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.20.1606222223530.10382@virtualbox \
    --to=johannes.schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).