From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/1] mingw: work around t2300's assuming non-Windows paths
Date: Wed, 22 Jun 2016 23:26:18 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1606222325560.10382@virtualbox> (raw)
In-Reply-To: <xmqqvb11kmog.fsf@gitster.mtv.corp.google.com>
Hi Junio,
On Wed, 22 Jun 2016, Junio C Hamano wrote:
> Junio C Hamano <gitster@pobox.com> writes:
>
> > I think I know that well enough; please sanity check. My
> > understanding is:
> > ...
> > The patch under discussion is the only door left for that test, and
> > a similar trickery is needed for any end-user scripts used for hooks
> > and aliases that use 'git --exec-path', if they ever want to be
> > cross-platform.
> >
> > So let's take that "if Windows do this" change to t2300 as-is.
>
> Assuming that the sanity check passes, here is a suggested rewrite
> to explain the real problem better.
Yes, the sanity check passes, and your commit message is much better than
mine.
Thanks!
Dscho
prev parent reply other threads:[~2016-06-22 21:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-18 10:49 [PATCH 0/1] Fix testing of `master` on Windows Johannes Schindelin
2016-06-18 10:49 ` [PATCH 1/1] mingw: work around t2300's assuming non-Windows paths Johannes Schindelin
2016-06-20 19:09 ` Junio C Hamano
2016-06-21 12:01 ` Johannes Schindelin
2016-06-21 17:10 ` Junio C Hamano
2016-06-21 17:27 ` Junio C Hamano
2016-06-22 8:25 ` Johannes Schindelin
2016-06-22 16:42 ` Junio C Hamano
2016-06-22 20:06 ` Johannes Schindelin
2016-06-22 20:12 ` Junio C Hamano
2016-06-22 21:26 ` Johannes Schindelin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1606222325560.10382@virtualbox \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).