From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Pranit Bauva <pranit.bauva@gmail.com>
Subject: Re: [PATCH 1/2] t3404: fix another typo
Date: Thu, 30 Jun 2016 10:17:48 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1606301017240.12947@virtualbox> (raw)
In-Reply-To: <xmqqh9cb50p3.fsf@gitster.mtv.corp.google.com>
Hi Junio,
On Wed, 29 Jun 2016, Junio C Hamano wrote:
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>
> > On Wed, 29 Jun 2016, Junio C Hamano wrote:
> >
> >> Johannes Schindelin <johannes.schindelin@gmx.de> writes:
> >>
> >> > The past tense of "to run" is "run", not "ran".
> >>
> >> Actually, past tense of the verb "to run" is "ran" ;-) The reason
> >> why this patch is still correct is because this is writing in
> >> passive voice, where you want "be + past participle", and the past
> >> participle of the verb "to run" is "run".
> >
> > Embarrassing! ;-)
> >
> > Well, I shall fix up the commit message thusly:
> >
> > t3404: fix another typo
> >
> > The passive form of "to run" is "run", not "ran".
>
> If your convention of referring to a verb is to show its infinitive
> form, i.e. "to run", then you would probably want to say
>
> The passive from of "to run" is "to be run", not "to be
> ran".
>
> But I think we do not need any of this if we just retitled it to
>
> Subject: t3404: fix a grammo (commands are ran -> commands are run)
>
> without any body.
Done. Will be part of v2.
Ciao,
Dscho
next prev parent reply other threads:[~2016-06-30 8:19 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-29 14:30 [PATCH 0/2] Late edits to the rebase -i tests Johannes Schindelin
2016-06-29 14:31 ` [PATCH 1/2] t3404: fix another typo Johannes Schindelin
2016-06-29 15:11 ` Pranit Bauva
2016-06-29 15:26 ` Junio C Hamano
2016-06-29 15:31 ` Johannes Schindelin
2016-06-29 18:06 ` Junio C Hamano
2016-06-30 8:17 ` Johannes Schindelin [this message]
2016-06-29 14:31 ` [PATCH 2/2] t3404: add a test for the --gpg-sign option Johannes Schindelin
2016-06-29 18:30 ` Junio C Hamano
2016-06-30 8:25 ` Johannes Schindelin
2016-07-01 16:06 ` Junio C Hamano
2016-07-02 7:38 ` Johannes Schindelin
2016-07-06 14:51 ` Junio C Hamano
2016-07-06 15:34 ` Johannes Schindelin
2016-07-06 19:02 ` Junio C Hamano
2016-07-07 15:23 ` Johannes Schindelin
2016-07-07 15:52 ` [PATCH v2 0/3] Additional rebase -i tests Johannes Schindelin
2016-07-07 15:52 ` [PATCH v2 1/3] t3404: add a test for the --gpg-sign option Johannes Schindelin
2016-07-07 15:52 ` [PATCH v2 2/3] rebase -i: demonstrate a bug with --autosquash Johannes Schindelin
2016-07-07 15:52 ` [PATCH v2 3/3] rebase -i: we allow extra spaces after fixup!/squash! Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1606301017240.12947@virtualbox \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pranit.bauva@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).