From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: David Turner <novalis@novalis.org>
Cc: git@vger.kernel.org, pclouds@gmail.com, kmaggg@gmail.com,
David Turner <dturner@twopensource.com>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v14 15/21] index-helper: kill mode
Date: Wed, 6 Jul 2016 10:20:03 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1607061016330.6426@virtualbox> (raw)
In-Reply-To: <1467532693-20017-16-git-send-email-novalis@novalis.org>
Hi Dave,
On Sun, 3 Jul 2016, David Turner wrote:
> @@ -357,10 +359,29 @@ static const char * const usage_text[] = {
> NULL
> };
>
> +static void request_kill(void)
> +{
> + int fd = unix_stream_connect(git_path("index-helper.sock"));
> +
> + if (fd >= 0) {
> + write_in_full(fd, "die", 4);
I believe that this is incorrect. When I interrupt t7900 after the 3rd
test case, it says
fatal: protocol error: bad line length character: die
twice, suggesting that this write_in_full() actually needs to be a
packet_write(fd, "die") instead, seeing as loop() uses the packet_read()
call to read the messages.
BTW I am in the middle of trying to abstract out a "simple server" that
will allow me to back the inter-process communication by a pure Windows
solution (named pipes) instead of the Unix sockets. It turns out to be
much more difficult than I hoped: the code is really relying on Unix
sockets currently.
Will keep you posted,
Dscho
next prev parent reply other threads:[~2016-07-06 8:24 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-03 7:57 [PATCH v14 00/21] index-helper/watchman David Turner
2016-07-03 7:57 ` [PATCH v14 01/21] read-cache: allow to keep mmap'd memory after reading David Turner
2016-07-03 7:57 ` [PATCH v14 02/21] pkt-line: add gentle version of packet_write David Turner
2016-07-03 7:57 ` [PATCH v14 03/21] unix-socket.c: add stub implementation when unix sockets are not supported David Turner
2016-07-03 7:57 ` [PATCH v14 04/21] index-helper: new daemon for caching index and related stuff David Turner
2016-07-03 7:57 ` [PATCH v14 05/21] index-helper: add --strict David Turner
2016-07-03 7:57 ` [PATCH v14 06/21] daemonize(): set a flag before exiting the main process David Turner
2016-07-03 7:57 ` [PATCH v14 07/21] index-helper: add --detach David Turner
2016-07-03 7:58 ` [PATCH v14 08/21] index-helper: log warnings David Turner
2016-07-03 7:58 ` [PATCH v14 09/21] read-cache: add watchman 'WAMA' extension David Turner
2016-07-03 7:58 ` [PATCH v14 10/21] watchman: support watchman to reduce index refresh cost David Turner
2016-07-03 7:58 ` [PATCH v14 11/21] index-helper: use watchman to avoid refreshing index with lstat() David Turner
2016-07-03 7:58 ` [PATCH v14 12/21] update-index: enable/disable watchman support David Turner
2016-07-03 7:58 ` [PATCH v14 13/21] unpack-trees: preserve index extensions David Turner
2016-07-03 7:58 ` [PATCH v14 14/21] watchman: add a config option to enable the extension David Turner
2016-07-03 7:58 ` [PATCH v14 15/21] index-helper: kill mode David Turner
2016-07-06 8:20 ` Johannes Schindelin [this message]
2016-07-06 15:33 ` Duy Nguyen
2016-07-03 7:58 ` [PATCH v14 16/21] index-helper: don't run if already running David Turner
2016-07-03 7:58 ` [PATCH v14 17/21] index-helper: autorun mode David Turner
2016-07-03 7:58 ` [PATCH v14 18/21] index-helper: optionally automatically run David Turner
2016-07-03 7:58 ` [PATCH v14 19/21] trace: measure where the time is spent in the index-heavy operations David Turner
2016-07-03 11:51 ` [PATCH v14 00/21] index-helper/watchman Johannes Schindelin
2016-07-04 6:40 ` Johannes Schindelin
2016-07-06 18:11 ` Junio C Hamano
2016-07-12 18:24 ` Duy Nguyen
2016-07-13 21:59 ` David Turner
2016-07-14 15:56 ` Duy Nguyen
2016-07-14 15:58 ` Duy Nguyen
2016-07-15 1:20 ` Ben Peart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1607061016330.6426@virtualbox \
--to=johannes.schindelin@gmx.de \
--cc=dturner@twopensource.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=kmaggg@gmail.com \
--cc=novalis@novalis.org \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).