From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Andrey Vagin <avagin@openvz.org>
Cc: Johannes Sixt <j6t@kdbg.org>, Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org
Subject: Re: [PATCH] git-clean: remove fifo, devices, socket files
Date: Fri, 15 Jul 2016 12:48:49 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1607151246190.6426@virtualbox> (raw)
In-Reply-To: <CANaxB-y6XW7-ps1G2CB=N9CiD0VnSLhSer2nsf+2R4pm5TyswA@mail.gmail.com>
Hi Andrey,
On Fri, 15 Jul 2016, Andrey Vagin wrote:
> What will be wrong if 'git status' will reports these [fifo/socket] files?
`git status` is intended to give you an idea what to commit next. And...
> What will be wrong if 'git add' will returns an error instead of
> skipping them silently?
... we *cannot* commit fifos or sockets. There is simply no representation
in Git's data model for them.
Having said that, I would welcome a patch that makes `git add` complain
about arguments that could not be added (and are not directories).
As to the patch in question, for the above-mentioned reasons, I think we
want to keep the existing behavior instead.
Ciao,
Johannes
next prev parent reply other threads:[~2016-07-15 10:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-15 2:42 [PATCH] git-clean: remove fifo, devices, socket files Andrey Vagin
2016-07-15 5:56 ` Johannes Sixt
2016-07-15 7:46 ` Andrey Vagin
2016-07-15 10:48 ` Johannes Schindelin [this message]
2016-07-15 20:33 ` Johannes Sixt
2016-07-15 21:36 ` Andrew Vagin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1607151246190.6426@virtualbox \
--to=johannes.schindelin@gmx.de \
--cc=avagin@openvz.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).