From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Ilya Tumaykin <itumaykin@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: Bug: "git log --format='format:%+s%+b'" doesn't insert newline before body
Date: Mon, 25 Jul 2016 09:33:00 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1607250926320.14111@virtualbox> (raw)
In-Reply-To: <8915446.47C9zkNvuX@photon>
Hi Ilya,
On Sun, 24 Jul 2016, Ilya Tumaykin wrote:
> Steps to reproduce:
> $ git init
> $ >123
> $ git add 123
> $ git commit -v -m 'This is subject' -m 'And this is body'
> $ git --no-pager log -1 --format='format:%+s%+b'
>
> Actual results:
> ```
>
> This is subject
> And this is body
> ```
>
> Expected results:
> ```
>
> This is subject
>
> And this is body
> ```
The empty line between commit subject and body is neither part of the
subject nor of the body. That means that the above-mentioned expectation
was incorrect.
Unless you somehow allow empty commit messages (Git does not, unless you
play games with low-level commands), the second '+' is unnecessarily
conditional. Therefore "%s%n%+b" *might* do what you intended (I would not
know, because that information was missing from the report).
Ciao,
Johannes
next prev parent reply other threads:[~2016-07-25 7:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-24 13:46 Bug: "git log --format='format:%+s%+b'" doesn't insert newline before body Ilya Tumaykin
2016-07-25 6:55 ` Bug: Beat Bolli
2016-07-25 7:33 ` Johannes Schindelin [this message]
2016-07-25 7:51 ` Bug: "git log --format='format:%+s%+b'" doesn't insert newline before body Ilya Tumaykin
2016-07-25 8:06 ` Johannes Schindelin
2016-07-25 10:49 ` Ilya Tumaykin
2016-07-25 17:28 ` Jakub Narębski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1607250926320.14111@virtualbox \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=itumaykin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).