From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Orgad Shaneh <orgads@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] commit: Fix description of no-verify
Date: Tue, 26 Jul 2016 14:55:08 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1607261452281.14111@virtualbox> (raw)
In-Reply-To: <1469519305-11361-1-git-send-email-orgad.shaneh@audiocodes.com>
Hi Orgad
On Tue, 26 Jul 2016, Orgad Shaneh wrote:
> From: Orgad Shaneh <orgads@gmail.com>
This is unnecessary, as it matches your email address.
> include also commit-msg hook.
This comment was a bit cryptic, until I read the patch. Now I find that
comment redundant with the patch.
However, I think that...
> - OPT_BOOL('n', "no-verify", &no_verify, N_("bypass pre-commit hook")),
> + OPT_BOOL('n', "no-verify", &no_verify, N_("bypass pre-commit and commit-msg hooks")),
... it may be more desirable to future-proof this simply by saying "bypass
hooks".
In the alternative, it would be good if the commit message could
convincingly make the case that there are no other hooks that will be
skipped with -n.
Of course, I could go and look at the source code to convince myself. But
it is really the duty of the commit message to be already convincing
enough.
Ciao,
Dscho
next prev parent reply other threads:[~2016-07-26 12:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-26 7:48 [PATCH] commit: Fix description of no-verify Orgad Shaneh
2016-07-26 12:55 ` Johannes Schindelin [this message]
2016-07-26 13:09 ` Orgad Shaneh
2016-07-26 13:43 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1607261452281.14111@virtualbox \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=orgads@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).