2.9.2 test failures on macOS

2.9.2 test failures on macOS

[Jeremy Huddleston Sequoia]

[-- Attachment #1: Type: text/plain, Size: 1049 bytes --]

I have two test failures to report in git 2.9.2 on macOS:


t3210-pack-refs.sh has not changed between 2.8.4 and 2.9.2.  This test passed fine with 2.8.4, but it now fails with 2.9.2 at:

not ok 26 - retry acquiring packed-refs.lock
#	
#		LOCK=.git/packed-refs.lock &&
#		>"$LOCK" &&
#		test_when_finished "wait; rm -f $LOCK" &&
#		{
#			( sleep 1 ; rm -f $LOCK ) &
#		} &&
#		git -c core.packedrefstimeout=3000 pack-refs --all --prune
#	

===

t3700-add.sh recently added the 'git add --chmod=-x stages an executable file with -x' test.  This test passes when run as a normal user but fails when run as root:

$ ./t3700-add.sh
...
# passed all 40 test(s)
1..40

$ sudo ./t3700-add.sh
...
not ok 39 - git add --chmod=-x stages an executable file with -x
#	
#		echo foo >xfoo1 &&
#		chmod 755 xfoo1 &&
#		git add --chmod=-x xfoo1 &&
#		case "$(git ls-files --stage xfoo1)" in
#		100644" "*xfoo1) echo pass;;
#		*) echo fail; git ls-files --stage xfoo1; (exit 1);;
#		esac
#	
# failed 1 among 40 test(s)
1..40


[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 4465 bytes --]

Re: 2.9.2 test failures on macOS

[Lars Schneider]

> On 03 Aug 2016, at 09:35, Jeremy Huddleston Sequoia <jeremyhu@macports.org> wrote:
> 
> I have two test failures to report in git 2.9.2 on macOS:
> 
> 
> t3210-pack-refs.sh has not changed between 2.8.4 and 2.9.2.  This test passed fine with 2.8.4, but it now fails with 2.9.2 at:
> 
> not ok 26 - retry acquiring packed-refs.lock
> #	
> #		LOCK=.git/packed-refs.lock &&
> #		>"$LOCK" &&
> #		test_when_finished "wait; rm -f $LOCK" &&
> #		{
> #			( sleep 1 ; rm -f $LOCK ) &
> #		} &&
> #		git -c core.packedrefstimeout=3000 pack-refs --all --prune
> #	
> 
> ===
> 
> t3700-add.sh recently added the 'git add --chmod=-x stages an executable file with -x' test.  This test passes when run as a normal user but fails when run as root:
> 
> $ ./t3700-add.sh
> ...
> # passed all 40 test(s)
> 1..40
> 
> $ sudo ./t3700-add.sh
> ...
> not ok 39 - git add --chmod=-x stages an executable file with -x
> #	
> #		echo foo >xfoo1 &&
> #		chmod 755 xfoo1 &&
> #		git add --chmod=-x xfoo1 &&
> #		case "$(git ls-files --stage xfoo1)" in
> #		100644" "*xfoo1) echo pass;;
> #		*) echo fail; git ls-files --stage xfoo1; (exit 1);;
> #		esac
> #	
> # failed 1 among 40 test(s)
> 1..40
> 

What OS version do you use? Can you run `sw_vers` in your terminal and share the result?

Thanks,
Lars

Re: 2.9.2 test failures on macOS

[Johannes Schindelin]

Hi Jeremy,

On Wed, 3 Aug 2016, Jeremy Huddleston Sequoia wrote:

> I have two test failures to report in git 2.9.2 on macOS:
> 
> 
> t3210-pack-refs.sh has not changed between 2.8.4 and 2.9.2.  This test passed fine with 2.8.4, but it now fails with 2.9.2 at:
> 
> not ok 26 - retry acquiring packed-refs.lock
> #	
> #		LOCK=.git/packed-refs.lock &&
> #		>"$LOCK" &&
> #		test_when_finished "wait; rm -f $LOCK" &&
> #		{
> #			( sleep 1 ; rm -f $LOCK ) &
> #		} &&
> #		git -c core.packedrefstimeout=3000 pack-refs --all --prune
> #	
> 
> ===
> 
> t3700-add.sh recently added the 'git add --chmod=-x stages an executable file with -x' test.  This test passes when run as a normal user but fails when run as root:
> 
> $ ./t3700-add.sh
> ...
> # passed all 40 test(s)
> 1..40
> 
> $ sudo ./t3700-add.sh
> ...
> not ok 39 - git add --chmod=-x stages an executable file with -x
> #	
> #		echo foo >xfoo1 &&
> #		chmod 755 xfoo1 &&
> #		git add --chmod=-x xfoo1 &&
> #		case "$(git ls-files --stage xfoo1)" in
> #		100644" "*xfoo1) echo pass;;
> #		*) echo fail; git ls-files --stage xfoo1; (exit 1);;
> #		esac
> #	
> # failed 1 among 40 test(s)
> 1..40

I tried to write up all I know about debugging test failures here:

https://github.com/git-for-windows/git/wiki/Running-Git's-regression-tests#running-individual-tests

Could you give it a try and diagnose the breakage further? (The output you
provided is unfortunately not enough to determine what went wrong.)

Ciao,
Johannes

Re: 2.9.2 test failures on macOS

[Jeremy Huddleston Sequoia]

[-- Attachment #1: Type: text/plain, Size: 2509 bytes --]


> On Aug 3, 2016, at 07:35, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
> 
> Hi Jeremy,
> 
> On Wed, 3 Aug 2016, Jeremy Huddleston Sequoia wrote:
> 
>> I have two test failures to report in git 2.9.2 on macOS:
>> 
>> 
>> t3210-pack-refs.sh has not changed between 2.8.4 and 2.9.2.  This test passed fine with 2.8.4, but it now fails with 2.9.2 at:
>> 
>> not ok 26 - retry acquiring packed-refs.lock
>> #	
>> #		LOCK=.git/packed-refs.lock &&
>> #		>"$LOCK" &&
>> #		test_when_finished "wait; rm -f $LOCK" &&
>> #		{
>> #			( sleep 1 ; rm -f $LOCK ) &
>> #		} &&
>> #		git -c core.packedrefstimeout=3000 pack-refs --all --prune
>> #
>> 
>> ===
>> 
>> t3700-add.sh recently added the 'git add --chmod=-x stages an executable file with -x' test.  This test passes when run as a normal user but fails when run as root:
>> 
>> $ ./t3700-add.sh
>> ...
>> # passed all 40 test(s)
>> 1..40
>> 
>> $ sudo ./t3700-add.sh
>> ...
>> not ok 39 - git add --chmod=-x stages an executable file with -x
>> #	
>> #		echo foo >xfoo1 &&
>> #		chmod 755 xfoo1 &&
>> #		git add --chmod=-x xfoo1 &&
>> #		case "$(git ls-files --stage xfoo1)" in
>> #		100644" "*xfoo1) echo pass;;
>> #		*) echo fail; git ls-files --stage xfoo1; (exit 1);;
>> #		esac
>> #	
>> # failed 1 among 40 test(s)
>> 1..40
> 
> I tried to write up all I know about debugging test failures here:
> 
> https://github.com/git-for-windows/git/wiki/Running-Git's-regression-tests#running-individual-tests
> 
> Could you give it a try and diagnose the breakage further? (The output you
> provided is unfortunately not enough to determine what went wrong.)

Another report indicates that the second was a known failure already.  As for the first one:

~/tmp/test $ git init
Initialized empty Git repository in /Users/jeremy/tmp/test/.git/

~/tmp/test (master) $ touch .git/packed-refs.lock 

~/tmp/test (master) $ git -c core.packedrefstimeout=3000 pack-refs --all --prune
fatal: Unable to create '/Users/jeremy/tmp/test/.git/packed-refs.lock': File exists.

Another git process seems to be running in this repository, e.g.
an editor opened by 'git commit'. Please make sure all processes
are terminated then try again. If it still fails, a git process
may have crashed in this repository earlier:
remove the file manually to continue.

--

I just tried this again with 2.8.4, and I see the same failure.  I could've sworn that 2.8.4 passed all tests when I tested it back in June.

[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 4465 bytes --]

Re: 2.9.2 test failures on macOS

[Junio C Hamano]

Jeremy Huddleston Sequoia <jeremyhu@macports.org> writes:

> t3700-add.sh recently added the 'git add --chmod=-x stages an executable file with -x' test.  This test passes when run as a normal user but fails when run as root:
>
> $ ./t3700-add.sh

This has been spotted and corrected on the development track
already, I think.  It will hopefully be in a future maintenance
release.

If you have a chance, perhaps you can fetch from my tree at
git.kernel.org:/pub/scm/git/git.git and merge 766cdc41 (t3700: add a
test_mode_in_index helper function, 2016-07-30) to confirm the fix?

Thanks.