Git development
 help / color / mirror / Atom feed
From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: "René Scharfe" <l.s.r@web.de>
Cc: Git List <git@vger.kernel.org>, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] merge-recursive: use STRING_LIST_INIT_NODUP
Date: Sun, 7 Aug 2016 10:51:01 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.20.1608071049510.5786@virtualbox> (raw)
In-Reply-To: <57A4FA24.4050505@web.de>

[-- Attachment #1: Type: text/plain, Size: 361 bytes --]

Hi René,

On Fri, 5 Aug 2016, René Scharfe wrote:

> Initialize a string_list right when it's defined.  That's shorter, saves
> a function call and makes it more obvious that we're using the NODUP
> variant here.

Thank you! I guess I never updated the code after the _INIT* macros were
introduced.

The change is good, of course.

Thanks,
Dscho

      reply	other threads:[~2016-08-07  8:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-05 20:42 [PATCH] merge-recursive: use STRING_LIST_INIT_NODUP René Scharfe
2016-08-07  8:51 ` Johannes Schindelin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.20.1608071049510.5786@virtualbox \
    --to=johannes.schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=l.s.r@web.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox