From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: "René Scharfe" <l.s.r@web.de>
Cc: Git List <git@vger.kernel.org>, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] use strbuf_add_unique_abbrev() for adding short hashes
Date: Sun, 7 Aug 2016 10:53:34 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1608071051540.5786@virtualbox> (raw)
In-Reply-To: <57A6050D.50200@web.de>
[-- Attachment #1: Type: text/plain, Size: 416 bytes --]
Hi René,
On Sat, 6 Aug 2016, René Scharfe wrote:
> Call strbuf_add_unique_abbrev() to add abbreviated hashes to strbufs
> instead of taking detours through find_unique_abbrev() and its static
> buffer. This is shorter and a bit more efficient.
And less error-prone.
It is also a thing I need to change in my upcoming rebase--helper patches:
I had not known about this function.
Thank you,
Dscho
next prev parent reply other threads:[~2016-08-07 8:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-06 15:41 [PATCH] use strbuf_add_unique_abbrev() for adding short hashes René Scharfe
2016-08-07 8:53 ` Johannes Schindelin [this message]
2016-08-07 23:14 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1608071051540.5786@virtualbox \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=l.s.r@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).