From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: "René Scharfe" <l.s.r@web.de>
Cc: Git List <git@vger.kernel.org>, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] introduce hex2chr() for converting two hexadecimal digits to a character
Date: Sun, 4 Sep 2016 09:49:20 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1609040947211.129229@virtualbox> (raw)
In-Reply-To: <ac454d89-e1cc-083e-5cea-fc9751de9a0f@web.de>
[-- Attachment #1: Type: text/plain, Size: 518 bytes --]
Hi René,
On Sat, 3 Sep 2016, René Scharfe wrote:
> Add and use a helper function that decodes the char value of two
> hexadecimal digits. It returns a negative number on error, avoids
> running over the end of the given string and doesn't shift negative
> values.
I like it! Maybe stress a little bit why this is a good change? Like, DRY
up code, makes the code safer (bt avoiding shifting negative values)?
> 6 files changed, 21 insertions(+), 78 deletions(-)
Very, very nice!
Thanks,
Dscho
next prev parent reply other threads:[~2016-09-04 7:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-03 15:59 [PATCH] introduce hex2chr() for converting two hexadecimal digits to a character René Scharfe
2016-09-04 7:49 ` Johannes Schindelin [this message]
2016-09-06 15:48 ` René Scharfe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1609040947211.129229@virtualbox \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=l.s.r@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).