From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: "René Scharfe" <l.s.r@web.de>, "Git List" <git@vger.kernel.org>
Subject: Re: [PATCH] compat: move strdup(3) replacement to its own file
Date: Thu, 8 Sep 2016 08:59:27 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1609080859160.129229@virtualbox> (raw)
In-Reply-To: <xmqqfupbob9c.fsf@gitster.mtv.corp.google.com>
[-- Attachment #1: Type: text/plain, Size: 943 bytes --]
Hi,
On Wed, 7 Sep 2016, Junio C Hamano wrote:
> René Scharfe <l.s.r@web.de> writes:
>
> > Well, OK. I think the missing point is that the original nedmalloc
> > doesn't come with strdup() and doesn't need it. Only _users_ of
> > nedmalloc need it. Marius added it in nedmalloc.c, but strdup.c is a
> > better place for it.
>
> Thanks. I'll add these lines like so:
>
> Move our implementation of strdup(3) out of compat/nedmalloc/ and
> allow it to be used independently from USE_NED_ALLOCATOR. The
> original nedmalloc doesn't come with strdup() and doesn't need it.
> Only _users_ of nedmalloc need it, which was added when we imported
> it to our compat/ hierarchy.
>
> This reduces the difference of our copy of nedmalloc from the
> original, making it easier to update, and allows for easier testing
> and reusing of our version of strdup().
Excellent!
Thanks,
Dscho
prev parent reply other threads:[~2016-09-08 6:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-03 15:59 [PATCH] compat: move strdup(3) replacement to its own file René Scharfe
2016-09-04 7:46 ` Johannes Schindelin
2016-09-06 15:40 ` René Scharfe
2016-09-07 17:44 ` Junio C Hamano
2016-09-08 6:59 ` Johannes Schindelin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1609080859160.129229@virtualbox \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=l.s.r@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).