From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: What's cooking in git.git (Sep 2016, #05; Mon, 19)
Date: Tue, 20 Sep 2016 23:50:01 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1609202349260.129229@virtualbox> (raw)
In-Reply-To: <xmqqd1jzcvs5.fsf@gitster.mtv.corp.google.com>
Hi,
On Mon, 19 Sep 2016, Junio C Hamano wrote:
> * jk/rebase-i-drop-ident-check (2016-07-29) 1 commit
> (merged to 'next' on 2016-08-14 at 6891bcd)
> + rebase-interactive: drop early check for valid ident
>
> Even when "git pull --rebase=preserve" (and the underlying "git
> rebase --preserve") can complete without creating any new commit
> (i.e. fast-forwards), it still insisted on having a usable ident
> information (read: user.email is set correctly), which was less
> than nice. As the underlying commands used inside "git rebase"
> would fail with a more meaningful error message and advice text
> when the bogus ident matters, this extra check was removed.
>
> Will hold to see if people scream.
> cf. <20160729224944.GA23242@sigill.intra.peff.net>
Let's do this.
Ciao,
Dscho
next prev parent reply other threads:[~2016-09-20 21:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-19 23:30 What's cooking in git.git (Sep 2016, #05; Mon, 19) Junio C Hamano
2016-09-20 21:50 ` Johannes Schindelin [this message]
2016-09-21 15:40 ` Junio C Hamano
2016-09-21 18:22 ` Johannes Schindelin
2016-09-21 9:11 ` Duy Nguyen
2016-09-21 15:44 ` Junio C Hamano
2016-09-21 16:26 ` Kevin Daudt
2016-09-21 17:36 ` Junio C Hamano
2016-09-21 17:45 ` Kevin Daudt
2016-09-22 6:49 ` Jeff King
2016-09-22 22:14 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1609202349260.129229@virtualbox \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).