git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: What's cooking in git.git (Dec 2016, #02; Mon, 12)
Date: Tue, 13 Dec 2016 16:39:46 +0100 (CET)	[thread overview]
Message-ID: <alpine.DEB.2.20.1612131638290.23160@virtualbox> (raw)
In-Reply-To: <xmqqoa0g96o3.fsf@gitster.mtv.corp.google.com>

Hi Junio,

On Mon, 12 Dec 2016, Junio C Hamano wrote:

> * js/mingw-isatty (2016-12-11) 1 commit
>   (merged to 'next' on 2016-12-12 at 60c1da6676)
>  + mingw: intercept isatty() to handle /dev/null as Git expects it
> 
>  We often decide if a session is interactive by checking if the
>  standard I/O streams are connected to a TTY, but isatty() emulation
>  on Windows incorrectly returned true if it is used on NUL (i.e. an
>  equivalent to /dev/null). This has been fixed.

I'd like to suggest a reword: we did not use an isatty() emulation, but
Windows' own _isatty() function that simply has different semantics than
what Git expected. *Now* we have an isatty() emulation that wraps
_isatty() and emulates the behavior expected by Git.

Thanks,
Dscho

  reply	other threads:[~2016-12-13 15:39 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-12 21:30 What's cooking in git.git (Dec 2016, #02; Mon, 12) Junio C Hamano
2016-12-13 15:39 ` Johannes Schindelin [this message]
2016-12-13 16:09   ` Junio C Hamano
2016-12-13 15:42 ` Johannes Schindelin
2016-12-13 16:13   ` Junio C Hamano
2016-12-19 10:49     ` Johannes Schindelin
2016-12-19 18:17       ` Junio C Hamano
2016-12-13 19:19 ` Johannes Schindelin
2016-12-13 19:28   ` Junio C Hamano
2016-12-13 21:37     ` Brandon Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.20.1612131638290.23160@virtualbox \
    --to=johannes.schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).