From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: "Kyle J. McKay" <mackyle@gmail.com>
Cc: Jeff King <peff@peff.net>,
Jonathan Tan <jonathantanmy@google.com>,
Junio C Hamano <gitster@pobox.com>,
Git mailing list <git@vger.kernel.org>
Subject: Re: [PATCH] mailinfo.c: move side-effects outside of assert
Date: Tue, 20 Dec 2016 15:12:35 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.20.1612201511480.54750@virtualbox> (raw)
In-Reply-To: <A916CED6-C49D-41D8-A7EE-A5FEDA641F4A@gmail.com>
Hi Kyle,
On Mon, 19 Dec 2016, Kyle J. McKay wrote:
> On Dec 19, 2016, at 09:45, Johannes Schindelin wrote:
>
> >ACK. I noticed this problem (and fixed it independently as a part of a
> >huge patch series I did not get around to submit yet) while trying to
> >get Git to build correctly with Visual C.
>
> Does this mean that Dscho and I are the only ones who add -DNDEBUG for
> release builds? Or are we just the only ones who actually run the test
> suite on such builds?
It seems you and I are for the moment the only ones bothering with running
the test suite on release builds.
Ciao,
Johannes
next prev parent reply other threads:[~2016-12-20 14:12 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-17 19:54 [PATCH] mailinfo.c: move side-effects outside of assert Kyle J. McKay
2016-12-19 17:45 ` Johannes Schindelin
2016-12-19 20:03 ` Jeff King
2016-12-19 20:38 ` Kyle J. McKay
2016-12-19 20:54 ` Jonathan Tan
2016-12-19 21:01 ` Junio C Hamano
2016-12-19 23:13 ` [PATCH v2] " Kyle J. McKay
2016-12-19 23:26 ` Junio C Hamano
2016-12-19 23:54 ` [PATCH v3] " Kyle J. McKay
2016-12-20 14:12 ` Johannes Schindelin [this message]
2016-12-20 16:45 ` [PATCH] " Jeff King
2016-12-21 5:54 ` Kyle J. McKay
2016-12-21 15:55 ` Jeff King
2016-12-22 2:21 ` Kyle J. McKay
2016-12-22 3:34 ` Jeff King
2016-12-22 17:57 ` Junio C Hamano
2016-12-22 3:53 ` Kyle J. McKay
2016-12-22 3:59 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1612201511480.54750@virtualbox \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jonathantanmy@google.com \
--cc=mackyle@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).