From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Johannes Sixt <j6t@kdbg.org>
Cc: git@vger.kernel.org, Jeff Hostetler <jeffhost@microsoft.com>,
Junio C Hamano <gitster@pobox.com>,
Pranit Bauva <pranit.bauva@gmail.com>,
Beat Bolli <dev+git@drbeat.li>
Subject: Re: [PATCH v2 3/3] mingw: replace isatty() hack
Date: Fri, 23 Dec 2016 00:18:04 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.20.1612230017030.155951@virtualbox> (raw)
In-Reply-To: <04859cf9-e67a-28ab-ccb3-249687e696c8@kdbg.org>
Hi Hannes,
On Thu, 22 Dec 2016, Johannes Sixt wrote:
> Am 22.12.2016 um 22:37 schrieb Johannes Schindelin:
>
> > Would you have a suggestion how to rephrase the comment to make it
> > less confusing?
>
> Perhaps
>
> * This might close the cached console handle.
> * We must cache the live duplicate instead.
>
> Then update the cache before the dup2, because at this time all 3 of console,
> handle, and duplicate are live and cannot be recycled:
>
> if (console == handle)
> console = duplicate;
> dup2(new_fd, fd);
Good point. I reworded the comment slightly differently (see the interdiff
in v3 0/3), hope you don't mind.
Ciao,
Dscho
next prev parent reply other threads:[~2016-12-22 23:18 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-21 17:53 [PATCH 0/2] Really fix the isatty() problem on Windows Johannes Schindelin
2016-12-21 17:53 ` [PATCH 1/2] mingw: adjust is_console() to work with stdin Johannes Schindelin
2016-12-21 17:53 ` [PATCH 2/2] mingw: replace isatty() hack Johannes Schindelin
2016-12-21 18:45 ` Junio C Hamano
2016-12-21 21:15 ` [PATCH 0/2] Really fix the isatty() problem on Windows Johannes Sixt
2016-12-21 21:21 ` Junio C Hamano
2016-12-22 18:48 ` Johannes Sixt
2016-12-22 21:33 ` Johannes Schindelin
2016-12-22 17:08 ` [PATCH v2 0/3] " Johannes Schindelin
2016-12-22 17:08 ` [PATCH v2 1/3] mingw: adjust is_console() to work with stdin Johannes Schindelin
2016-12-22 23:04 ` Beat Bolli
2016-12-22 23:18 ` Junio C Hamano
2016-12-23 9:30 ` Johannes Schindelin
2016-12-23 12:51 ` Beat Bolli
2016-12-22 17:09 ` [PATCH v2 2/3] mingw: fix colourization on Cygwin pseudo terminals Johannes Schindelin
2016-12-22 17:09 ` [PATCH v2 3/3] mingw: replace isatty() hack Johannes Schindelin
2016-12-22 20:26 ` Johannes Sixt
2016-12-22 21:37 ` Johannes Schindelin
2016-12-22 22:28 ` Johannes Sixt
2016-12-22 23:18 ` Johannes Schindelin [this message]
2016-12-22 17:49 ` [PATCH v2 0/3] Really fix the isatty() problem on Windows Junio C Hamano
2016-12-22 17:59 ` Johannes Schindelin
2016-12-22 18:32 ` Junio C Hamano
2016-12-22 18:19 ` Junio C Hamano
2016-12-22 23:16 ` [PATCH v3 " Johannes Schindelin
2016-12-22 23:16 ` [PATCH v3 1/3] mingw: adjust is_console() to work with stdin Johannes Schindelin
2016-12-22 23:16 ` [PATCH v3 2/3] mingw: fix colourization on Cygwin pseudo terminals Johannes Schindelin
2016-12-22 23:16 ` [PATCH v3 3/3] mingw: replace isatty() hack Johannes Schindelin
2017-01-18 12:13 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1612230017030.155951@virtualbox \
--to=johannes.schindelin@gmx.de \
--cc=dev+git@drbeat.li \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
--cc=jeffhost@microsoft.com \
--cc=pranit.bauva@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox