From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Brandon Williams <bmwill@google.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] sequencer: fix missing newline
Date: Thu, 23 Mar 2017 18:40:33 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.20.1703231839570.3767@virtualbox> (raw)
In-Reply-To: <20170323170233.50499-1-bmwill@google.com>
Hi Brandon,
On Thu, 23 Mar 2017, Brandon Williams wrote:
> When using rebase --interactive where one of the lines is marked as
> 'edit' this is the resulting output:
>
> Stopped at ec3b9c4... stuffYou can amend the commit now, with
Ugh, I should have caught this. The warning() call implicitly adds a
newline, the fprintf() doesn't.
Patch is obviously good.
Thanks,
Dscho
next prev parent reply other threads:[~2017-03-23 17:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-23 17:02 [PATCH] sequencer: fix missing newline Brandon Williams
2017-03-23 17:40 ` Johannes Schindelin [this message]
2017-03-23 17:47 ` Brandon Williams
2017-03-23 18:22 ` Jeff King
2017-03-23 18:24 ` Jeff King
2017-03-23 18:24 ` Brandon Williams
2017-03-23 18:19 ` Junio C Hamano
2017-03-23 22:12 ` Jonathan Nieder
2017-03-23 22:38 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1703231839570.3767@virtualbox \
--to=johannes.schindelin@gmx.de \
--cc=bmwill@google.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).