From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Brandon Williams <bmwill@google.com>
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Jeff King" <peff@peff.net>,
"Git Mailing List" <git@vger.kernel.org>,
"Jonathan Nieder" <jrnieder@gmail.com>,
frank@gevaerts.be
Subject: Re: [RFC] dropping support for ancient versions of curl
Date: Wed, 5 Apr 2017 00:46:16 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1704050043370.4268@virtualbox> (raw)
In-Reply-To: <20170404165321.GC189807@google.com>
Hi Brandon,
On Tue, 4 Apr 2017, Brandon Williams wrote:
> I'm all for seeing a patch like this applied. I agree that we can't
> expect the world to be running the most up-to-date version of curl but
> we should be able to select some "oldest" version we will support which
> can be bumped up every couple of years.
>
> I mean, ensuring that you are running with an up-to-date version of curl
> is really important when it comes to all of the security fixes that have
> been made in each revision.
I am not in the business of dictating to others what software they have to
run. I am in the business of maintaining Git for Windows. And part of that
job is to drag along code that is maybe not the most elegant, but works.
The patch in question resolves such a wart. Sure, it would be a cleanup.
Is it a huge maintenance burden to keep those few #ifdef's, though?
Absolutely not.
Ciao,
Johannes
next prev parent reply other threads:[~2017-04-04 22:46 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-04 2:54 [RFC] dropping support for ancient versions of curl Jeff King
2017-04-04 3:08 ` Jeff King
2017-04-04 5:44 ` Jessie Hernandez
2017-04-04 8:17 ` Ævar Arnfjörð Bjarmason
2017-04-04 8:33 ` Jeff King
2017-04-04 10:44 ` Ævar Arnfjörð Bjarmason
2017-04-04 11:54 ` Johannes Schindelin
2017-04-04 14:06 ` Ævar Arnfjörð Bjarmason
2017-04-04 16:53 ` Brandon Williams
2017-04-04 22:46 ` Johannes Schindelin [this message]
2017-04-04 23:03 ` Brandon Williams
2017-04-04 23:03 ` Stefan Beller
2017-04-05 8:49 ` Johannes Schindelin
2017-04-05 9:29 ` Jeff King
2017-04-04 20:16 ` Jeff King
2017-04-04 13:32 ` Frank Gevaerts
2017-04-05 9:33 ` Tom G. Christensen
2017-04-05 10:51 ` Ævar Arnfjörð Bjarmason
2017-04-05 13:04 ` [PATCH 0/7] Patches to support older RHEL releases Tom G. Christensen
2017-04-05 13:04 ` [PATCH 1/7] Make NO_PERL_MAKEMAKER behave more like ExtUtils::MakeMaker Tom G. Christensen
2017-04-05 13:04 ` [PATCH 2/7] Install man pages when NO_PERL_MAKEMAKER is used Tom G. Christensen
2017-04-05 13:04 ` [PATCH 3/7] Allow svnrdump_sim.py to be used with Python 2.2 Tom G. Christensen
2017-04-05 13:40 ` Ævar Arnfjörð Bjarmason
2017-04-05 14:36 ` Tom G. Christensen
2017-04-05 13:04 ` [PATCH 4/7] Handle missing HTTP_CONNECTCODE in curl < 7.10.7 Tom G. Christensen
2017-04-05 13:50 ` Ævar Arnfjörð Bjarmason
2017-04-05 15:58 ` Franke, Knut
2017-04-05 13:04 ` [PATCH 5/7] Add support for gnupg < 1.4 Tom G. Christensen
2017-04-05 13:45 ` Ævar Arnfjörð Bjarmason
2017-04-13 6:31 ` Junio C Hamano
2017-04-13 15:17 ` Ævar Arnfjörð Bjarmason
2017-04-05 13:04 ` [PATCH 6/7] Handle missing CURLINFO_SSL_DATA_{IN,OUT} Tom G. Christensen
2017-04-05 13:52 ` Ævar Arnfjörð Bjarmason
2017-04-05 13:04 ` [PATCH 7/7] Do not use curl_easy_strerror with curl < 7.12.0 Tom G. Christensen
2017-04-05 13:53 ` Ævar Arnfjörð Bjarmason
2017-04-06 9:18 ` Jeff King
2017-04-13 6:28 ` Junio C Hamano
2017-04-13 10:52 ` Jacob Keller
2017-04-05 13:04 ` [RFC] dropping support for ancient versions of curl Tom G. Christensen
2017-04-06 0:53 ` brian m. carlson
2017-04-06 1:16 ` Todd Zullinger
2017-04-06 9:29 ` Jeff King
2017-04-07 11:18 ` Johannes Schindelin
2017-04-10 18:22 ` Jeff King
2017-04-06 9:21 ` Jeff King
2017-04-06 16:43 ` Tom G. Christensen
2017-04-07 4:54 ` Jeff King
2017-04-14 11:12 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1704050043370.4268@virtualbox \
--to=johannes.schindelin@gmx.de \
--cc=avarab@gmail.com \
--cc=bmwill@google.com \
--cc=frank@gevaerts.be \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).