From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Jonathan Tan <jonathantanmy@google.com>
Cc: git@vger.kernel.org, computersforpeace@gmail.com
Subject: Re: [PATCH] sequencer: require trailing NL in footers
Date: Tue, 25 Apr 2017 23:56:36 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1704252355440.3480@virtualbox> (raw)
In-Reply-To: <20170425190651.8910-1-jonathantanmy@google.com>
Hi Jonathan,
On Tue, 25 Apr 2017, Jonathan Tan wrote:
> Thanks for the bug report. Here's a fix - I've verified this with the
> way to reproduce provided in the original e-mail, and it seems to work
> now.
If there is a straight-forward way to convert the manual test into an
automated one, it would be good to make it part of the patch so that we
can stave off future regressions of the fix.
Ciao,
Dscho
next prev parent reply other threads:[~2017-04-25 21:56 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-21 22:01 [GIT 2.12.2 REGRESSION] git cherry-pick -x Brian Norris
2017-04-21 22:10 ` Stefan Beller
2017-04-21 22:13 ` Jeff King
2017-04-25 19:06 ` [PATCH] sequencer: require trailing NL in footers Jonathan Tan
2017-04-25 21:04 ` Stefan Beller
2017-04-25 21:51 ` Jonathan Tan
2017-04-25 21:56 ` Stefan Beller
2017-04-25 22:05 ` Johannes Schindelin
2017-04-25 23:39 ` Jonathan Nieder
2017-04-25 22:30 ` Brian Norris
2017-04-26 20:31 ` Brian Norris
2017-04-25 21:56 ` Johannes Schindelin [this message]
2017-04-25 23:34 ` Jonathan Nieder
2017-04-25 23:57 ` [PATCH v2] " Jonathan Tan
2017-04-26 0:07 ` Jonathan Nieder
2017-04-26 2:08 ` Junio C Hamano
2017-04-26 9:09 ` Johannes Schindelin
2017-04-26 20:50 ` [PATCH v3] sequencer: add newline before adding footers Jonathan Tan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1704252355440.3480@virtualbox \
--to=johannes.schindelin@gmx.de \
--cc=computersforpeace@gmail.com \
--cc=git@vger.kernel.org \
--cc=jonathantanmy@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).