From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Lars Schneider <larsxschneider@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v1] travis-ci: printf $STATUS as string
Date: Wed, 26 Apr 2017 21:49:28 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1704262147550.3480@virtualbox> (raw)
In-Reply-To: <20170426193933.28961-1-larsxschneider@gmail.com>
Hi,
On Wed, 26 Apr 2017, Lars Schneider wrote:
> If the $STATUS variable contains a "%" character then printf will
> interpret that as invalid format string. Fix this by formatting $STATUS
> as string.
>
> Signed-off-by: Lars Schneider <larsxschneider@gmail.com>
ACK.
For reference, the status should always be a single all-ASCII word, but
sometimes it looks as if there is a server error that returns a full-blown
HTML error page (including a style that contains something like 'width:
10%;' which would be misinterpreted by printf as a format string).
Ciao,
Dscho
prev parent reply other threads:[~2017-04-26 19:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-26 19:39 [PATCH v1] travis-ci: printf $STATUS as string Lars Schneider
2017-04-26 19:49 ` Johannes Schindelin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1704262147550.3480@virtualbox \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=larsxschneider@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).