From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: Daniel Ferreira <bnmvco@gmail.com>,
Git Mailing List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 2/3] add--interactive: add builtin helper for interactive add
Date: Mon, 8 May 2017 13:35:20 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.21.1.1705081334440.146734@virtualbox> (raw)
In-Reply-To: <CACBZZX6_GbqNpTXTB8UQJzvD2nx_UTN8fwHV8Aczg+b9XoO_tg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 952 bytes --]
Hi,
On Sat, 6 May 2017, Ævar Arnfjörð Bjarmason wrote:
> On Sat, May 6, 2017 at 12:30 AM, Johannes Schindelin
> <Johannes.Schindelin@gmx.de> wrote:
> > Hi Daniel,
> >
> >
> > On Fri, 5 May 2017, Daniel Ferreira wrote:
> >> +static void print_modified(void)
> >> +{
> >> + int i;
> >> + struct add_interactive_status s;
> >> + const char *modified_fmt = _("%12s %12s %s");
> >
> > We cannot really translate that...
>
> He copied this from the *.perl code:
>
> # TRANSLATORS: you can adjust this to align "git add -i" status menu
> my $status_fmt = __('%12s %12s %s');
>
> And one translation at least makes use of that (and probably others should).
>
> But porting the /* TRANSLATORS: ... */ comment over is missing, and
> should be added.
Ah, that explains it. It still is not really translateable, but with the
comment, even *I* understand why it is marked for translation.
Thanks,
Dscho
next prev parent reply other threads:[~2017-05-08 11:35 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-05 18:43 [PATCH 0/3] Port git-add--interactive.perl:status_cmd to C Daniel Ferreira
2017-05-05 18:43 ` [PATCH 1/3] diff: export diffstat interface Daniel Ferreira
2017-05-05 21:28 ` Johannes Schindelin
2017-05-05 18:43 ` [PATCH 2/3] add--interactive: add builtin helper for interactive add Daniel Ferreira
2017-05-05 20:16 ` Ævar Arnfjörð Bjarmason
2017-05-05 21:21 ` Johannes Schindelin
2017-05-05 22:09 ` Ævar Arnfjörð Bjarmason
2017-05-05 22:30 ` Johannes Schindelin
2017-05-05 22:49 ` Ævar Arnfjörð Bjarmason
2017-05-08 11:35 ` Johannes Schindelin [this message]
2017-05-05 23:13 ` Daniel Ferreira (theiostream)
2017-05-05 23:28 ` Ævar Arnfjörð Bjarmason
2017-05-08 12:15 ` Johannes Schindelin
2017-05-05 18:43 ` [PATCH 3/3] add--interactive: use add-interactive--helper for status_cmd Daniel Ferreira
2017-05-05 22:32 ` Johannes Schindelin
2017-05-05 19:31 ` [PATCH 0/3] Port git-add--interactive.perl:status_cmd to C Ævar Arnfjörð Bjarmason
2017-05-05 22:33 ` Johannes Schindelin
2017-05-05 22:35 ` Jonathan Nieder
2017-05-05 22:38 ` Johannes Schindelin
2017-05-05 23:37 ` Daniel Ferreira (theiostream)
2017-05-08 12:23 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1.1705081334440.146734@virtualbox \
--to=johannes.schindelin@gmx.de \
--cc=avarab@gmail.com \
--cc=bnmvco@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).