git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Jeff King <peff@peff.net>
Cc: Kevin Willford <kcwillford@gmail.com>,
	git@vger.kernel.org, gitster@pobox.com,
	Kevin Willford <kewillf@microsoft.com>
Subject: Re: [PATCH 1/2] format-patch: have progress option while generating patches
Date: Thu, 1 Jun 2017 13:15:57 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.21.1.1706011312510.3610@virtualbox> (raw)
In-Reply-To: <20170531220100.t27w3w642sn33h7s@sigill.intra.peff.net>

Hi Peff,

On Wed, 31 May 2017, Jeff King wrote:

> I'm generally in favor of progress meters, though it does seem a little
> funny to me that we'd need one on format-patch.

When working with huge repositories with a large number of branches, it is
all too easy to pick the wrong branch to rebase to. In that case, it can
take a long time for the `git rebase` call to even generate the mbox.

Kevin's patch is a visual indication when this is happening.

Instead of being puzzled by `git rebase` "hanging", the user will now see
that (.../21957) patch is generated and will have a chance to say "wait a
minute, *that* many patches? I think I meant a different branch".

And since format-patch generates the patches for `git rebase` (actually,
it generates an mbox that then has to be split again, but you get the
gist), it is format-patch that needs to output the progress.

Ciao,
dscho

  parent reply	other threads:[~2017-06-01 11:16 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-31 15:04 [PATCH 0/2] Add progress to format-patch and rebase Kevin Willford
2017-05-31 15:04 ` [PATCH 1/2] format-patch: have progress option while generating patches Kevin Willford
2017-05-31 18:40   ` Stefan Beller
2017-05-31 19:31     ` Kevin Willford
2017-05-31 22:01   ` Jeff King
2017-06-01  4:10     ` Junio C Hamano
2017-06-01 11:15     ` Johannes Schindelin [this message]
2017-06-01 15:54       ` Jeff King
2017-05-31 15:04 ` [PATCH 2/2] rebase: turn on progress option by default for format-patch Kevin Willford
2017-05-31 19:08   ` Stefan Beller
2017-05-31 19:46     ` Kevin Willford
2017-05-31 20:27       ` Stefan Beller
2017-06-01 11:11     ` Johannes Schindelin
2017-05-31 22:11   ` Jeff King
2017-06-03 23:45     ` Junio C Hamano
2017-08-10 18:32 ` [PATCH v2 0/2] Add progress for format-patch and rebase Kevin Willford
2017-08-10 22:48   ` Junio C Hamano
2017-08-10 23:17     ` Jeff King
2017-08-10 18:32 ` [PATCH v2 1/2] format-patch: have progress option while generating patches Kevin Willford
2017-08-10 23:20   ` Jeff King
2017-08-11 22:18     ` Junio C Hamano
2017-08-12  8:06       ` Philip Oakley
2017-08-13  4:39         ` Jeff King
2017-08-14 16:45           ` Junio C Hamano
2017-08-14 18:35             ` Junio C Hamano
2017-08-14 22:29               ` Jeff King
2017-08-14 22:42                 ` Junio C Hamano
2017-08-14 23:08                   ` Jeff King
2017-08-14 23:23                     ` Junio C Hamano
2017-08-19 17:39                 ` [PATCH] progress: simplify "delayed" progress API Junio C Hamano
2017-08-19 20:58                   ` Junio C Hamano
2017-08-20  7:43                   ` Jeff King
2017-08-10 18:32 ` [PATCH v2 2/2] rebase: turn on progress option by default for format-patch Kevin Willford
2017-08-11 22:22   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.21.1.1706011312510.3610@virtualbox \
    --to=johannes.schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=kcwillford@gmail.com \
    --cc=kewillf@microsoft.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).