From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: "René Scharfe" <l.s.r@web.de>
Cc: Git List <git@vger.kernel.org>, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] win32: plug memory leak on realloc() failure in syslog()
Date: Mon, 14 Aug 2017 22:26:45 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.21.1.1708142225330.19382@virtualbox> (raw)
In-Reply-To: <245410ce-1f4c-f2a9-fd8d-98ff2d2c0335@web.de>
[-- Attachment #1: Type: text/plain, Size: 405 bytes --]
Hi René,
On Thu, 10 Aug 2017, René Scharfe wrote:
> If realloc() fails then the original buffer is still valid. Free it
> before exiting the function.
>
> Signed-off-by: Rene Scharfe <l.s.r@web.de>
The subject had me worried for a second... The realloc() fails so rarely
that I, for one, have never encountered that problem.
Still, it is a correct fix for a real bug.
Thanks,
Dscho
prev parent reply other threads:[~2017-08-14 20:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-10 10:23 [PATCH] win32: plug memory leak on realloc() failure in syslog() René Scharfe
2017-08-14 20:26 ` Johannes Schindelin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1.1708142225330.19382@virtualbox \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=l.s.r@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox