From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Kevin Daudt <me@ikke.info>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] status: do not get confused by submodules in excluded directories
Date: Wed, 25 Oct 2017 15:26:49 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.21.1.1710251522530.6482@virtualbox> (raw)
In-Reply-To: <20171024082029.GB7987@alpha.vpn.ikke.info>
Hi Kevin,
On Tue, 24 Oct 2017, Kevin Daudt wrote:
> On Tue, Oct 17, 2017 at 03:10:11PM +0200, Johannes Schindelin wrote:
> > diff --git a/t/t7061-wtstatus-ignore.sh b/t/t7061-wtstatus-ignore.sh
> > index fc6013ba3c8..8c849a4cd2f 100755
> > --- a/t/t7061-wtstatus-ignore.sh
> > +++ b/t/t7061-wtstatus-ignore.sh
> > @@ -272,4 +272,18 @@ test_expect_success 'status ignored tracked directory with uncommitted file in t
> > test_cmp expected actual
> > '
> >
> > +cat >expected <<\EOF
> > +!! tracked/submodule/
> > +EOF
> > +
> > +test_expect_success 'status ignores submodule in excluded directory' '
> > + git init tracked/submodule &&
> > + (
> > + cd tracked/submodule &&
> > + test_commit initial
> > + ) &&
>
> Could this use test_commit -C tracked/submodule initial?
Yes! Thanks. For some reason, I did not even think that test_commit would
accept the -C option.
Ciao,
Dscho
next prev parent reply other threads:[~2017-10-25 13:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-17 13:10 [PATCH] status: do not get confused by submodules in excluded directories Johannes Schindelin
2017-10-24 5:18 ` Junio C Hamano
2017-10-24 12:15 ` Heiko Voigt
2017-10-24 15:34 ` Stefan Beller
2017-10-25 1:28 ` Junio C Hamano
2017-10-25 14:04 ` Heiko Voigt
2017-10-25 20:39 ` Johannes Schindelin
2017-10-24 8:20 ` Kevin Daudt
2017-10-25 13:26 ` Johannes Schindelin [this message]
2017-10-25 20:40 ` [PATCH v2 0/1] Do not handle submodules in excluded directories as untracked Johannes Schindelin
2017-10-25 20:40 ` [PATCH v2 1/1] status: do not get confused by submodules in excluded directories Johannes Schindelin
2017-10-26 2:28 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1.1710251522530.6482@virtualbox \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=me@ikke.info \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).