From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Heiko Voigt <hvoigt@hvoigt.net>
Cc: Junio C Hamano <gitster@pobox.com>,
Stefan Beller <sbeller@google.com>,
git@vger.kernel.org
Subject: Re: [PATCH] status: do not get confused by submodules in excluded directories
Date: Wed, 25 Oct 2017 22:39:17 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.21.1.1710252238390.6482@virtualbox> (raw)
In-Reply-To: <20171025140414.GA1368@book.hvoigt.net>
Hi,
On Wed, 25 Oct 2017, Heiko Voigt wrote:
> On Wed, Oct 25, 2017 at 10:28:25AM +0900, Junio C Hamano wrote:
> > Heiko Voigt <hvoigt@hvoigt.net> writes:
> >
> > > On Tue, Oct 24, 2017 at 02:18:49PM +0900, Junio C Hamano wrote:
> > >> Johannes Schindelin <johannes.schindelin@gmx.de> writes:
> > >>
> > >> > We meticulously pass the `exclude` flag to the `treat_directory()`
> > >> > function so that we can indicate that files in it are excluded rather
> > >> > than untracked when recursing.
> > >> >
> > >> > But we did not yet treat submodules the same way.
> > >>
> > >> ... "because of that, we ended up showing <<what incorrect result in
> > >> what situation>>" would be a nice thing to have here, so that it can
> > >> be copied to the release notes for the bugfix.
> > >
> > > Yes I agree that would be nice here. It was not immediately obvious that
> > > this only applies when using both flags: -u and --ignored.
> >
> > Does any of you care to fill in the <<blanks above>> then? ;-)
>
> How about:
>
> Because of that, we ended up showing the submodule as untracked and its
> content as ignored files when using the --ignored and -u flags with git
> status.
>
> ? But maybe Dscho also has some more information to add about his
> situation?
He has... as part of v2, a substantially more detailed commit message will
reach your inbox Real Soon Now.
Ciao,
Dscho
next prev parent reply other threads:[~2017-10-25 20:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-17 13:10 [PATCH] status: do not get confused by submodules in excluded directories Johannes Schindelin
2017-10-24 5:18 ` Junio C Hamano
2017-10-24 12:15 ` Heiko Voigt
2017-10-24 15:34 ` Stefan Beller
2017-10-25 1:28 ` Junio C Hamano
2017-10-25 14:04 ` Heiko Voigt
2017-10-25 20:39 ` Johannes Schindelin [this message]
2017-10-24 8:20 ` Kevin Daudt
2017-10-25 13:26 ` Johannes Schindelin
2017-10-25 20:40 ` [PATCH v2 0/1] Do not handle submodules in excluded directories as untracked Johannes Schindelin
2017-10-25 20:40 ` [PATCH v2 1/1] status: do not get confused by submodules in excluded directories Johannes Schindelin
2017-10-26 2:28 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1.1710252238390.6482@virtualbox \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=hvoigt@hvoigt.net \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).