From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Adam Dinwoodie <adam@dinwoodie.org>
Cc: git@vger.kernel.org, Johannes Sixt <j6t@kdbg.org>
Subject: Re: [PATCH] t5580: add Cygwin support
Date: Tue, 31 Oct 2017 18:39:54 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.21.1.1710311839340.6482@virtualbox> (raw)
In-Reply-To: <20171031131903.10496-1-adam@dinwoodie.org>
Hi Adam,
On Tue, 31 Oct 2017, Adam Dinwoodie wrote:
> t5580 tests that specifying Windows UNC paths works with Git. Cygwin
> supports UNC paths, albeit only using forward slashes, not backslashes,
> so run the compatible tests on Cygwin as well as MinGW.
>
> The only complication is Cygwin's `pwd`, which returns a *nix-style
> path, and that's not suitable for calculating the UNC path to the
> current directory. Instead use Cygwin's `cygpath` utility to get the
> Windows-style path.
Looks good!
Thank you,
Dscho
next prev parent reply other threads:[~2017-10-31 17:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-31 13:19 [PATCH] t5580: add Cygwin support Adam Dinwoodie
2017-10-31 17:39 ` Johannes Schindelin [this message]
2017-11-01 1:44 ` Junio C Hamano
2017-11-01 10:17 ` Adam Dinwoodie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1.1710311839340.6482@virtualbox \
--to=johannes.schindelin@gmx.de \
--cc=adam@dinwoodie.org \
--cc=git@vger.kernel.org \
--cc=j6t@kdbg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).