git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Matthew Orres <matthew.orres@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: Git 2.15.0 on OSX 10.12.6: gui multi-select stage
Date: Wed, 1 Nov 2017 22:58:20 +0100 (CET)	[thread overview]
Message-ID: <alpine.DEB.2.21.1.1711012254380.6482@virtualbox> (raw)
In-Reply-To: <CAKbB5OwxQ4XtLXuu2w3QmuKryA=3iHupz=y0m2E1NH+Dwzd8Xw@mail.gmail.com>

Hi Matthew,

On Wed, 1 Nov 2017, Matthew Orres wrote:

> Using 2.15.0 on OSX 10.12.6, when I open git gui, and then attempt to
> stage multiple files as such:
> 
> * Left click first file
> * CMD+Shift+Click last file to multi-select all files
> * CMT+T (shortcut for Stage to Commit)
> 
> Only the file I selected with the first Left Click is staged and my
> selection disappears.
> 
> I'd be happy to provide more system-level info if there's issues with
> reproducing this on other machines.

Maybe you'll be also happy to test things?

I believe that we carry a fix for this in Git for Windows:
https://github.com/git-for-windows/git/commit/3a5640fd3f0aa57edecc8dab455a97c5a15e6626

The easiest way to test this would be to simply build Git from the
`master` branch of https://github.com/git-for-windows/git (I try to keep
it building and passing the test suite at all times not only on Windows,
but also on Linux, it should also work on macOS).

Ciao,
Johannes

P.S.: If you test this, and can confirm that it fixes your issue, I'll get
this patch submitted properly to the Git mailing list (sadly, it seems
that the https://github.com/patthoyts/git-gui project is sleeping beauty
mode for a while now, otherwise I would add PRs there).

  reply	other threads:[~2017-11-01 21:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-01 18:59 Git 2.15.0 on OSX 10.12.6: gui multi-select stage Matthew Orres
2017-11-01 21:58 ` Johannes Schindelin [this message]
2018-01-05 20:26   ` Matthew Orres
2018-01-05 21:10     ` Johannes Schindelin
     [not found]     ` <CAKbB5OxFTycBVhzyow9Op2M=HcBWKhLEii-putehS0ONNw=W=A@mail.gmail.com>
     [not found]       ` <nycvar.QRO.7.76.6.1801052240440.1337@wbunaarf-fpuvaqryva.tvgsbejvaqbjf.bet>
2018-01-05 21:50         ` Matthew Orres
2018-01-06 12:13           ` Johannes Schindelin
2018-01-06 12:20             ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.21.1.1711012254380.6482@virtualbox \
    --to=johannes.schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=matthew.orres@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).