Git development
 help / color / mirror / Atom feed
From: Julia Lawall <julia.lawall@lip6.fr>
To: git@vger.kernel.org
Subject: git blame --reverse reports on lines that were not asked for
Date: Sun, 13 Jan 2019 08:07:04 +0100 (CET)	[thread overview]
Message-ID: <alpine.DEB.2.21.1901130758180.4448@hadrien> (raw)

Version: git version 2.17.1, git version 2.20.1

Git tree:
https://kernel.googlesource.com/pub/scm/linux/kernel/git/stable/linux-stable
7566ec393f4161572ba6f11ad5171fd5d59b0fbd

The command git blame --reverse 91e4f1b6073dd680d86cdb7e42d7cccca9db39d8..HEAD -L1176,1176 -L1173,1173 arch/mips/kvm/emulate.c

Produces:

693dfd5a3f19e (Erez Shitrit 2017-04-27 17:01:34 +0300 1173)                                     preempt_disable();
693dfd5a3f19e (Erez Shitrit 2017-04-27 17:01:34 +0300 1174)                                     /* Blow away the shadow host TLBs */

Line 1174 was not asked for, and there is no information about line 1176.

git blame --reverse 91e4f1b6073dd680d86cdb7e42d7cccca9db39d8..HEAD -L1173,1173 -L1175,1175 arch/mips/kvm/emulate.c works fine:

693dfd5a3f19e (Erez Shitrit 2017-04-27 17:01:34 +0300 1173)                                     preempt_disable();
f3124cc551c85 (James Hogan  2016-09-16 00:00:08 +0100 1175)                                     kvm_mips_flush_host_tlb(1);

git blame --reverse 91e4f1b6073dd680d86cdb7e42d7cccca9db39d8..HEAD -L1173,1176 arch/mips/kvm/emulate.c also works fine:

693dfd5a3f19e (Erez Shitrit 2017-04-27 17:01:34 +0300 1173)                                     preempt_disable();
f3124cc551c85 (James Hogan  2016-09-16 00:00:08 +0100 1174)                                     /* Blow away the shadow host TLBs */
f3124cc551c85 (James Hogan  2016-09-16 00:00:08 +0100 1175)                                     kvm_mips_flush_host_tlb(1);
693dfd5a3f19e (Erez Shitrit 2017-04-27 17:01:34 +0300 1176)                                     cpu = smp_processor_id();

My impression is that git --reverse blame is not all that reliable, and we can even see that 1174 gets assigned to two different commits depending on how the command is formulated.  But I would expect it to at least report on only and exactly the lines that were asked for.

thanks,
julia

                 reply	other threads:[~2019-01-13  7:07 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.21.1901130758180.4448@hadrien \
    --to=julia.lawall@lip6.fr \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox