From: Nicolas Pitre <nico@cam.org>
To: Junio C Hamano <junkio@cox.net>
Cc: Dana How <danahow@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH 10/13] update delta handling in write_object() for --pack-limit
Date: Thu, 05 Apr 2007 20:43:40 -0400 (EDT) [thread overview]
Message-ID: <alpine.LFD.0.98.0704052040170.28181@xanadu.home> (raw)
In-Reply-To: <7v3b3emmv6.fsf@assigned-by-dhcp.cox.net>
On Thu, 5 Apr 2007, Junio C Hamano wrote:
> (3) makes me wonder if we can still allow it in the thin-pack
> case by just loosening the condition here.
I don't think thin packs apply in the sliced pack usage scenario anyway.
>
> Also I need explanation to understand why (4) is needed --
> doesn't write_one() always write base object out before writing
> a deltified object that depends on it?
Yes it does. This is a requirement for OBJ_OFS_DELTA.
Nicolas
prev parent reply other threads:[~2007-04-06 0:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-05 22:38 [PATCH 10/13] update delta handling in write_object() for --pack-limit Dana How
2007-04-05 23:18 ` Junio C Hamano
2007-04-05 23:41 ` Dana How
2007-04-06 0:43 ` Nicolas Pitre [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.0.98.0704052040170.28181@xanadu.home \
--to=nico@cam.org \
--cc=danahow@gmail.com \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).