From: Nicolas Pitre <nico@cam.org>
To: "Shawn O. Pearce" <spearce@spearce.org>
Cc: Dana How <danahow@gmail.com>, Junio C Hamano <junkio@cox.net>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] Create pack-write.c for common pack writing code
Date: Wed, 02 May 2007 12:29:40 -0400 (EDT) [thread overview]
Message-ID: <alpine.LFD.0.98.0705021226010.6574@xanadu.home> (raw)
In-Reply-To: <20070502161648.GK5942@spearce.org>
On Wed, 2 May 2007, Shawn O. Pearce wrote:
> Dana How <danahow@gmail.com> wrote:
> >
> > Include a generalized fixup_header_footer() in this new file.
> > Needed by git-repack --max-pack-size feature in a later patchset.
>
> Thanks. I'm applying this to my fastimport.git tree, but I changed
> the name to fixup_pack_header_footer(). I'm also refactoring the
> same code out of index-pack, to call your version.
>
> I'll ask Junio to pull your patch, and my index-pack cleanup soon.
> As soon as I'm sure everything still passes the tests. ;-)
BTW I think the common function should _not_ close the file descriptor
it is being handed. It is more flexible to let the caller close the
file, or possibly do whatever other operations like fchmod().
Nicolas
next prev parent reply other threads:[~2007-05-02 16:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-01 18:26 [PATCH] Create pack-write.c for common pack writing code Dana How
2007-05-02 16:16 ` Shawn O. Pearce
2007-05-02 16:29 ` Nicolas Pitre [this message]
2007-05-02 16:31 ` Shawn O. Pearce
2007-05-02 17:25 ` Dana How
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.0.98.0705021226010.6574@xanadu.home \
--to=nico@cam.org \
--cc=danahow@gmail.com \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).