From: Linus Torvalds <torvalds@linux-foundation.org>
To: Junio C Hamano <junkio@cox.net>, Git Mailing List <git@vger.kernel.org>
Subject: Re: Finally implement "git log --follow"
Date: Wed, 20 Jun 2007 18:15:11 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.0.98.0706201811440.3593@woody.linux-foundation.org> (raw)
In-Reply-To: <alpine.LFD.0.98.0706191358180.3593@woody.linux-foundation.org>
Junio, I note that you merged this into 'next', and also:
On Tue, 19 Jun 2007, Linus Torvalds wrote:
>
> [ long and boring explanation ]
>
> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
> ----
Note the *four* dashes instead of three, so:
> NOTE! For obvious enough reasons, I limited the rename following to just
> *one* pathname. If somebody wants to extend it to any more, be my guest.
>
> Also, I really might have some silly bug somewhere.
>
> "It Works For Me(tm)", and I tested it with both the git archive and the
> kernel (block/ll_rw_block.c) and it worked beautifully, but I'll also
> admit that the patch is a bit _too_ clever for my taste normally. The
> patch actually looks more straightforward than it really is: that "hook
> directly into diff_tree_sha1()" thing is just too damn clever for words.
>
> People who want to improve on it should get rid of the memory leak I
> introduced - I decided to not bother cleaning up the whole rename diff
> queue, I just reset it. I'm lazy, and I'm a *man*. I do the rough manly
> stuff, others can clean up after me.
>
> *Burp*. That hit the spot. *Scratch*
This also hit the git archives.
My burping and scratching wasn't really *meant* to be part of the official
record, but hey, there you have it.
No problem, and maybe you noticed and thought it amusing, but in case it
went unnoticed, you may want to clean that up when/if moving it to
"master".
Or not. Your choice.
Linus
next prev parent reply other threads:[~2007-06-21 1:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-19 21:22 Finally implement "git log --follow" Linus Torvalds
2007-06-19 21:35 ` Linus Torvalds
2007-07-04 13:21 ` Marco Costalba
2007-06-20 6:27 ` Marco Costalba
2007-06-20 16:47 ` Linus Torvalds
2007-06-21 6:21 ` Marco Costalba
2007-06-21 15:44 ` Linus Torvalds
2007-06-21 15:55 ` Johannes Schindelin
2007-06-21 16:09 ` Linus Torvalds
2007-06-21 1:15 ` Linus Torvalds [this message]
2007-06-21 1:37 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.0.98.0706201811440.3593@woody.linux-foundation.org \
--to=torvalds@linux-foundation.org \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).