From: Nicolas Pitre <nico@cam.org>
To: Dana How <danahow@gmail.com>
Cc: Junio C Hamano <junkio@cox.net>, Git Mailing List <git@vger.kernel.org>
Subject: Re: [RFD/PATCH] Implement pack.compression and pack-objects --compression=N
Date: Fri, 04 May 2007 16:17:35 -0400 (EDT) [thread overview]
Message-ID: <alpine.LFD.0.99.0705041609260.24220@xanadu.home> (raw)
In-Reply-To: <56b7f5510705041251v1a09103eif677c02efc53059e@mail.gmail.com>
On Fri, 4 May 2007, Dana How wrote:
> Now that I'm awake your original quote at the top suggests:
> (a) zlib_compression_level =
> isset(core.loosecompression) ? core.loosecompression :
> isset(core.compression) ? core.compression : Z_BEST_SPEED;
> (b) pack_compression_level =
> isset(pack.compression) ? pack.compression :
> isset(core.compression) ? core.compression : Z_DEFAULT_COMPRESSION;
>
> Your later reaction to my quoted (a)/(b) table suggests:
> (a) zlib_compression_level =
> isset(core.compression) ? core.compression : Z_BEST_SPEED;
> (b) pack_compresion_level =
> isset(pack.compression) ? pack.compression : Z_DEFAULT_COMPRESSION;
My final comment is that I think the former looks more coherent, while
the later is simpler to implement.
Nicolas
prev parent reply other threads:[~2007-05-04 20:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-02 3:18 [RFD/PATCH] Implement pack.compression and pack-objects --compression=N Dana How
2007-05-02 18:40 ` Junio C Hamano
2007-05-02 18:55 ` Dana How
2007-05-02 22:51 ` Dana How
2007-05-04 5:49 ` Junio C Hamano
2007-05-04 7:01 ` Dana How
2007-05-04 13:47 ` Nicolas Pitre
2007-05-04 16:10 ` Dana How
2007-05-04 16:30 ` Nicolas Pitre
2007-05-04 19:51 ` Dana How
2007-05-04 20:17 ` Nicolas Pitre [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.0.99.0705041609260.24220@xanadu.home \
--to=nico@cam.org \
--cc=danahow@gmail.com \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).