From: Nicolas Pitre <nico@cam.org>
To: Martin Koegler <mkoegler@auto.tuwien.ac.at>
Cc: Junio C Hamano <junkio@cox.net>, git@vger.kernel.org
Subject: Re: [PATCH 1/3] builtin-pack-objects: don't fail, if delta is not possible
Date: Mon, 28 May 2007 22:45:16 -0400 (EDT) [thread overview]
Message-ID: <alpine.LFD.0.99.0705282243280.11491@xanadu.home> (raw)
In-Reply-To: <11803872591522-git-send-email-mkoegler@auto.tuwien.ac.at>
On Mon, 28 May 2007, Martin Koegler wrote:
> If builtin-pack-objects runs out of memory while finding
> the best deltas, it bails out with an error.
>
> If the delta index creation fails (because there is not enough memory),
> we can downgrade the error message to a warning and continue with the
> next object.
In the same vain, there is one realloc() that was turned into a
xrealloc() in diff-delta.c. I think this was a mistake and should
probably be a non fatal realloc again to let the caller go on.
Nicolas
next prev parent reply other threads:[~2007-05-29 2:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-28 21:20 [PATCH 1/3] builtin-pack-objects: don't fail, if delta is not possible Martin Koegler
2007-05-28 21:20 ` [PATCH 2/3] git-pack-objects: cache small deltas between big objects Martin Koegler
2007-05-28 21:20 ` [PATCH 3/3] builtin-pack-object: cache small deltas Martin Koegler
2007-05-29 0:33 ` Dana How
2007-05-29 2:45 ` Nicolas Pitre [this message]
2007-05-29 2:53 ` [PATCH 1/3] builtin-pack-objects: don't fail, if delta is not possible Shawn O. Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.0.99.0705282243280.11491@xanadu.home \
--to=nico@cam.org \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=mkoegler@auto.tuwien.ac.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).