From: Nicolas Pitre <nico@cam.org>
To: Junio C Hamano <junkio@cox.net>
Cc: Martin Koegler <mkoegler@auto.tuwien.ac.at>, git@vger.kernel.org
Subject: Re: [PATCH] diff-delta: use realloc instead of xrealloc
Date: Tue, 29 May 2007 22:57:06 -0400 (EDT) [thread overview]
Message-ID: <alpine.LFD.0.99.0705292252220.11491@xanadu.home> (raw)
In-Reply-To: <7v1wgz5gus.fsf@assigned-by-dhcp.cox.net>
On Tue, 29 May 2007, Junio C Hamano wrote:
> Martin Koegler <mkoegler@auto.tuwien.ac.at> writes:
>
> > Commit 83572c1a914d3f7a8dd66d954c11bbc665b7b923 changed many
> > realloc to xrealloc. This change was made in diff-delta.c too,
> > although the code can handle an out of memory failure.
> >
> > This patch reverts this change in diff-delta.c.
>
> Wasn't there a discussion around this exact issue when the
> original patch was applied?
Maybe, but I cannot remember it, not can I justify that xrealloc now.
Nicolas
next prev parent reply other threads:[~2007-05-30 2:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-29 19:08 [PATCH] diff-delta: use realloc instead of xrealloc Martin Koegler
2007-05-29 23:51 ` Junio C Hamano
2007-05-30 2:57 ` Nicolas Pitre [this message]
2007-05-30 6:17 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.0.99.0705292252220.11491@xanadu.home \
--to=nico@cam.org \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=mkoegler@auto.tuwien.ac.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).