From: Nicolas Pitre <nico@cam.org>
To: Dana How <danahow@gmail.com>
Cc: Geert Bosch <bosch@gnat.com>, git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] Unify write_index_file functions
Date: Fri, 01 Jun 2007 17:01:00 -0400 (EDT) [thread overview]
Message-ID: <alpine.LFD.0.99.0706011655130.12885@xanadu.home> (raw)
In-Reply-To: <56b7f5510706011316v6e4c6f9fj33ae61f0b30f1772@mail.gmail.com>
On Fri, 1 Jun 2007, Dana How wrote:
> (2) write_idx_file has a sha1 argument with different in & out meanings,
> requiring copies at some call sites. Should this be 2 separate args?
I think the copy could be avoided entirely. The pack_file_sha1 array
doesn't need to have global scope. The simple sha1[20] array with this
patch can serve the pack_file_sha1 purpose as well just fine.
Nicolas
next prev parent reply other threads:[~2007-06-01 21:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-01 19:18 [PATCH] Unify write_index_file functions Geert Bosch
2007-06-01 20:15 ` Junio C Hamano
2007-06-01 19:18 ` Geert Bosch
2007-06-01 20:16 ` Dana How
2007-06-01 21:01 ` Nicolas Pitre [this message]
2007-06-01 20:54 ` Nicolas Pitre
[not found] <alpine.LFD.0.99.0706012126260.12885@xanadu.home>
2007-06-01 19:18 ` Geert Bosch
2007-06-02 2:04 ` Nicolas Pitre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.0.99.0706011655130.12885@xanadu.home \
--to=nico@cam.org \
--cc=bosch@gnat.com \
--cc=danahow@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).