From: Nicolas Pitre <nico@cam.org>
To: Johan Herland <johan@herland.net>
Cc: git@vger.kernel.org,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
gitster@pobox.com
Subject: Re: [PATCH] fsck: do not crash on tag objects which do not contain an empty line
Date: Thu, 07 Jun 2007 22:04:22 -0400 (EDT) [thread overview]
Message-ID: <alpine.LFD.0.99.0706072158160.12885@xanadu.home> (raw)
In-Reply-To: <200706080128.48637.johan@herland.net>
On Fri, 8 Jun 2007, Johan Herland wrote:
> I agree that we should fail gracefully, and my code is clearly not doing
> that in this case. My bad.
>
> But the code should also detect invalid tag objects, and in this case I'm
> not yet convinced that the tag object causing the failure is in fact valid.
> If someone can convince me that the blank line after headers is optional,
> then I'll gladly fix the code.
That's irrelevant.
Because you are fed invalid data is no excuse for crashing.
Especially in a tool like fsck, you should _expect_ and cope with
invalid data. That's why it exists in the first place: to identify such
data.
Nicolas
next prev parent reply other threads:[~2007-06-08 2:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-07 22:40 [PATCH] fsck: do not crash on tag objects which do not contain an empty line Johannes Schindelin
2007-06-07 23:08 ` Johan Herland
2007-06-07 23:13 ` Johannes Schindelin
2007-06-07 23:28 ` Johan Herland
2007-06-07 23:38 ` Johannes Schindelin
2007-06-08 2:04 ` Nicolas Pitre [this message]
2007-06-08 2:14 ` Johan Herland
2007-06-08 5:17 ` Junio C Hamano
2007-06-08 5:30 ` Johannes Schindelin
2007-06-08 8:32 ` Andy Parkins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.0.99.0706072158160.12885@xanadu.home \
--to=nico@cam.org \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johan@herland.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).