git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: David Frech <nimblemachines@gmail.com>, git@vger.kernel.org
Subject: Re: test suite fails if sh != bash || tar != GNU tar
Date: Tue, 10 Jul 2007 20:22:24 -0700 (PDT)	[thread overview]
Message-ID: <alpine.LFD.0.999.0707102020020.3412@woody.linux-foundation.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0707110347580.4047@racer.site>



On Wed, 11 Jul 2007, Johannes Schindelin wrote:
> 
> Actually, Ubuntu seems to ship with dash as the default shell, and we had 
> quite some fallout from that change.

Well, part of it was really dash bugs, no? The whole "'shift' on an empty 
argument list" seemed to be a total and outright dash bug, and wasn't 
about relying on bash "features".

But we've had tons of issues with different spacing for "wc -l" etc, so 
yeah, the silly details matter even when there aren't outright bugs in 
tools.

> As for GNU tar, I think that this is easily fixable if you have access to 
> non-GNU tar.  We do not use tar _ever_, except for the test suite, to 
> verify that things are working as expected.
> 
> If you could put in some time to make the tests work, that would be 
> awesome.

Yeah, it would be a good thing to get rid of any bashisms, but to _keep_ 
it working somebody would then need to test every once in a while that it 
still works ;)

		Linus

  reply	other threads:[~2007-07-11  3:23 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-11  2:39 test suite fails if sh != bash || tar != GNU tar David Frech
2007-07-11  2:49 ` Johannes Schindelin
2007-07-11  3:22   ` Linus Torvalds [this message]
2007-07-11  4:08     ` David Frech
2007-07-11 11:09       ` Johannes Schindelin
2007-07-11 21:26         ` Junio C Hamano
2007-07-11 21:33           ` David Frech
2007-07-11 21:43             ` Junio C Hamano
2007-07-11 21:57               ` David Frech
2007-07-11 21:56             ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.0.999.0707102020020.3412@woody.linux-foundation.org \
    --to=torvalds@linux-foundation.org \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=nimblemachines@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).