git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: git-log --follow?
Date: Thu, 12 Jul 2007 12:01:24 -0700 (PDT)	[thread overview]
Message-ID: <alpine.LFD.0.999.0707121154240.20061@woody.linux-foundation.org> (raw)
In-Reply-To: <7vsl7ttq97.fsf@assigned-by-dhcp.cox.net>



On Thu, 12 Jul 2007, Junio C Hamano wrote:
> 
> Yeah, I just tried the blame from 'pu' (I have been carrying
> that original patch from you there).  The output is not very
> intuitive in that it talks about each commit but it is not
> apparent _why_ the command talks about that commit.  Maybe
> adding "there are the lines in the final image of the blob you
> are blaming that came from this commit" to the output would make
> the output easier to read.

That doesn't necessarily work, at least not incrementally. The same commit 
can show up multiple times for *different* 'blame_entry' things, and I 
don't think we want to show such a commit multiple times, and I also don't 
think we know what all the blame entries are going to be until the end.

So right now I use that METAINFO_SHOWN flag to just show the commit once. 
That makes the log a *lot* more readable.

In my original patch (the one you apparently have in 'pu'), I did that 
differently (and not very well), but maybe that approach lends itself 
better to showing some kind of patch.

I think my newer version is likely better.

		Linus

  reply	other threads:[~2007-07-12 19:01 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-04 20:35 [BUG (or misfeature?)] git checkout and symlinks Pierre Habouzit
2007-07-04 20:52 ` Junio C Hamano
2007-07-04 21:05   ` Pierre Habouzit
2007-07-04 22:23     ` $ " Pierre Habouzit
2007-07-12  8:04 ` Teach read-tree 2-way merge to ignore intermediate symlinks Junio C Hamano
2007-07-12  8:31   ` git-log --follow? Junio C Hamano
2007-07-12 10:44     ` Johannes Schindelin
2007-07-12 17:49     ` Linus Torvalds
2007-07-12 18:45       ` Junio C Hamano
2007-07-12 19:01         ` Linus Torvalds [this message]
2007-07-12 12:40   ` Teach read-tree 2-way merge to ignore intermediate symlinks Pierre Habouzit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.0.999.0707121154240.20061@woody.linux-foundation.org \
    --to=torvalds@linux-foundation.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).